Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix JSON examples for commit comments #82

Merged
merged 4 commits into from

2 participants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 18, 2012
  1. @bgrainger

    Fix user login in example.

    bgrainger authored
  2. @bgrainger
  3. @bgrainger

    Add 'line' value to commit comment response.

    bgrainger authored
    Note that the 'line' value will often be greater than the 'position'
    value.
  4. @bgrainger
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 3 deletions.
  1. +5 −3 lib/resources.rb
View
8 lib/resources.rb
@@ -259,11 +259,13 @@ def json(key)
})
COMMIT_COMMENT = {
- "url" => "https://api.github.com/repos/octocat/Hello-World/pulls/comments/1",
+ "html_url" => "https://github.com/octocat/Hello-World/commit/6dcb09b5b57875f334f61aebed695e2e4193db5e#commitcomment-1",
+ "url" => "https://api.github.com/repos/octocat/Hello-World/comments/1",
"id" => 1,
"body" => "Great stuff",
"path" => "file1.txt",
"position" => 4,
+ "line" => 14,
"commit_id" => "6dcb09b5b57875f334f61aebed695e2e4193db5e",
"user" => USER,
"created_at" => "2011-04-14T16:00:49Z",
@@ -277,8 +279,8 @@ def json(key)
"additions" => 103,
"deletions" => 21,
"changes" => 124,
- "blob_url" => "https://github.com/octocate/Hello-World/blob/6dcb09b5b57875f334f61aebed695e2e4193db5e/file1.txt",
- "raw_url" => "https://github.com/octocate/Hello-World/raw/6dcb09b5b57875f334f61aebed695e2e4193db5e/file1.txt",
+ "blob_url" => "https://github.com/octocat/Hello-World/blob/6dcb09b5b57875f334f61aebed695e2e4193db5e/file1.txt",
+ "raw_url" => "https://github.com/octocat/Hello-World/raw/6dcb09b5b57875f334f61aebed695e2e4193db5e/file1.txt",
"patch" => "@@ -132,7 +132,7 @@ module Test @@ -1000,7 +1000,7 @@ module Test"
}
Something went wrong with that request. Please try again.