From cb0941d41d92e4c6835e28aeb427c22f555d96c1 Mon Sep 17 00:00:00 2001 From: Steve Schilinski Date: Wed, 10 Aug 2022 18:33:17 -0700 Subject: [PATCH 1/7] Add 3.6 performance numbers --- ...github-actions-for-github-enterprise-server.md | 15 +++++++++++++++ .../actions/hardware-requirements-3.6.md | 6 ++++++ 2 files changed, 21 insertions(+) create mode 100644 data/reusables/actions/hardware-requirements-3.6.md diff --git a/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md b/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md index 0aa32d5fea72..08a8d3ea454f 100644 --- a/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md +++ b/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md @@ -80,6 +80,21 @@ Maximum concurrency was measured using multiple repositories, job duration of ap {%- endif %} + +{%- ifversion ghes = 3.6 %} + +{% data reusables.actions.hardware-requirements-3.6 %} + +{% data variables.product.company_short %} measured maximum concurrency using multiple repositories, job duration of approximately 10 minutes, and 10 MB artifact uploads. You may experience different performance depending on the overall levels of activity on your instance. + +{% note %} + +**Note:** Beginning with {% data variables.product.prodname_ghe_server %} 3.5, {% data variables.product.company_short %}'s internal testing uses 3rd generation CPUs to better reflect a typical customer configuration. This change in CPU represents a small portion of the changes to performance targets in this version of {% data variables.product.prodname_ghe_server %}. + +{% endnote %} + +{%- endif %} + If you plan to enable {% data variables.product.prodname_actions %} for the users of an existing instance, review the levels of activity for users and automations on the instance and ensure that you have provisioned adequate CPU and memory for your users. For more information about monitoring the capacity and performance of {% data variables.product.prodname_ghe_server %}, see "[Monitoring your appliance](/admin/enterprise-management/monitoring-your-appliance)." For more information about minimum hardware requirements for {% data variables.product.product_location %}, see the hardware considerations for your instance's platform. diff --git a/data/reusables/actions/hardware-requirements-3.6.md b/data/reusables/actions/hardware-requirements-3.6.md new file mode 100644 index 000000000000..5bb8c2c0f310 --- /dev/null +++ b/data/reusables/actions/hardware-requirements-3.6.md @@ -0,0 +1,6 @@ +| vCPUs | Memory | Maximum Concurrency | +| :---| :--- | :--- | +| 8 | 64 GB | 740 jobs | +| 32 | 160 GB | 2700 jobs | +| 96 | 384 GB | 7000 jobs | +| 128 | 512 GB | 7000 jobs | From 9d9cf28c813d5ed0a0a114c95d7c0d1a02ae89cc Mon Sep 17 00:00:00 2001 From: Steve Schilinski Date: Wed, 10 Aug 2022 18:52:47 -0700 Subject: [PATCH 2/7] Update to connected runners --- ...with-github-actions-for-github-enterprise-server.md | 9 ++++++--- data/reusables/actions/hardware-requirements-3.6.md | 10 +++++----- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md b/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md index 08a8d3ea454f..b0d4d58ef4f7 100644 --- a/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md +++ b/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md @@ -85,14 +85,17 @@ Maximum concurrency was measured using multiple repositories, job duration of ap {% data reusables.actions.hardware-requirements-3.6 %} -{% data variables.product.company_short %} measured maximum concurrency using multiple repositories, job duration of approximately 10 minutes, and 10 MB artifact uploads. You may experience different performance depending on the overall levels of activity on your instance. +{% data variables.product.company_short %} measured maximum connected runners using multiple repositories, job duration of approximately 10 minutes, and 10 MB artifact uploads. You may experience different performance depending on the overall levels of activity on your instance. {% note %} -**Note:** Beginning with {% data variables.product.prodname_ghe_server %} 3.5, {% data variables.product.company_short %}'s internal testing uses 3rd generation CPUs to better reflect a typical customer configuration. This change in CPU represents a small portion of the changes to performance targets in this version of {% data variables.product.prodname_ghe_server %}. - +**Note:** Beginning with {% data variables.product.prodname_ghe_server %} 3.6, {% data variables.product.company_short %} documents connected runners as opposed to concurrent runners. Connected runners resprents the most runners you can connect and expect to utilize. {% endnote %} +{% note %} + +**Note:** Beginning with {% data variables.product.prodname_ghe_server %} 3.5, {% data variables.product.company_short %}'s internal testing uses 3rd generation CPUs to better reflect a typical customer configuration. This change in CPU represents a small portion of the changes to performance targets in this version of {% data variables.product.prodname_ghe_server %}. +{% endnote %} {%- endif %} If you plan to enable {% data variables.product.prodname_actions %} for the users of an existing instance, review the levels of activity for users and automations on the instance and ensure that you have provisioned adequate CPU and memory for your users. For more information about monitoring the capacity and performance of {% data variables.product.prodname_ghe_server %}, see "[Monitoring your appliance](/admin/enterprise-management/monitoring-your-appliance)." diff --git a/data/reusables/actions/hardware-requirements-3.6.md b/data/reusables/actions/hardware-requirements-3.6.md index 5bb8c2c0f310..5028ea19769c 100644 --- a/data/reusables/actions/hardware-requirements-3.6.md +++ b/data/reusables/actions/hardware-requirements-3.6.md @@ -1,6 +1,6 @@ -| vCPUs | Memory | Maximum Concurrency | +| vCPUs | Memory | Maximum Connected Runners | | :---| :--- | :--- | -| 8 | 64 GB | 740 jobs | -| 32 | 160 GB | 2700 jobs | -| 96 | 384 GB | 7000 jobs | -| 128 | 512 GB | 7000 jobs | +| 8 | 64 GB | 740 runners | +| 32 | 160 GB | 2700 runners | +| 96 | 384 GB | 7000 runners | +| 128 | 512 GB | 7000 runners | From 66e87aa046ee1cb61c62bfb62f9847b641ae0cb3 Mon Sep 17 00:00:00 2001 From: Steve Schilinski Date: Wed, 10 Aug 2022 19:10:08 -0700 Subject: [PATCH 3/7] fix formating --- ...with-github-actions-for-github-enterprise-server.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md b/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md index b0d4d58ef4f7..f70f29e9481a 100644 --- a/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md +++ b/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md @@ -33,7 +33,8 @@ This article explains how site administrators can configure {% data variables.pr ## Review hardware requirements -{%- ifversion ghes %} + +{%- ifversion ghes < 3.6 %} The CPU and memory resources available to {% data variables.product.product_location %} determine the number of jobs that can be run concurrently without performance loss. {% data reusables.actions.minimum-hardware %} @@ -41,6 +42,13 @@ The peak quantity of concurrent jobs running without performance loss depends on {% endif %} +{%- ifversion ghes > 3.5 %} + +The CPU and memory resources available to {% data variables.product.product_location %} determine the number of connected runners that can be obtained without performance loss. {% data reusables.actions.minimum-hardware %} + +The peak quantity of connected runners without performance loss depends on such factors as job duration, artifact usage, number of repositories running Actions, and how much other work your instance is doing not related to Actions. Internal testing at GitHub demonstrated the following performance targets for GitHub Enterprise Server on a range of CPU and memory configurations: + +{% endif %} {%- ifversion ghes = 3.2 %} From ad0be25d372f9efaef5ec869798de501e9be5d35 Mon Sep 17 00:00:00 2001 From: Steve Schilinski <53361486+bquantump@users.noreply.github.com> Date: Thu, 11 Aug 2022 13:17:39 -0700 Subject: [PATCH 4/7] Update content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md Code review suggestion Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com> --- ...-started-with-github-actions-for-github-enterprise-server.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md b/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md index f70f29e9481a..ee6dc88a0d0d 100644 --- a/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md +++ b/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md @@ -44,7 +44,7 @@ The peak quantity of concurrent jobs running without performance loss depends on {%- ifversion ghes > 3.5 %} -The CPU and memory resources available to {% data variables.product.product_location %} determine the number of connected runners that can be obtained without performance loss. {% data reusables.actions.minimum-hardware %} +The CPU and memory resources available to {% data variables.product.product_location %} determine the number of runners that can be configured without performance loss. {% data reusables.actions.minimum-hardware %} The peak quantity of connected runners without performance loss depends on such factors as job duration, artifact usage, number of repositories running Actions, and how much other work your instance is doing not related to Actions. Internal testing at GitHub demonstrated the following performance targets for GitHub Enterprise Server on a range of CPU and memory configurations: From a0b98c321084d181b01cddee099333fa2cbd3a8f Mon Sep 17 00:00:00 2001 From: Steve Schilinski <53361486+bquantump@users.noreply.github.com> Date: Thu, 11 Aug 2022 13:20:04 -0700 Subject: [PATCH 5/7] Update content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com> --- ...-started-with-github-actions-for-github-enterprise-server.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md b/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md index ee6dc88a0d0d..9d57d34a2791 100644 --- a/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md +++ b/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md @@ -97,7 +97,7 @@ Maximum concurrency was measured using multiple repositories, job duration of ap {% note %} -**Note:** Beginning with {% data variables.product.prodname_ghe_server %} 3.6, {% data variables.product.company_short %} documents connected runners as opposed to concurrent runners. Connected runners resprents the most runners you can connect and expect to utilize. +**Note:** Beginning with {% data variables.product.prodname_ghe_server %} 3.6, {% data variables.product.company_short %} documents connected runners as opposed to concurrent jobs. Connected runners represents the most runners you can connect and expect to utilize. {% endnote %} {% note %} From b433045ad93464ba7de6745bea7b2a18e9363e70 Mon Sep 17 00:00:00 2001 From: Steve Schilinski Date: Thu, 11 Aug 2022 13:25:24 -0700 Subject: [PATCH 6/7] Add setence on performance in regards to connected runners --- ...-started-with-github-actions-for-github-enterprise-server.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md b/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md index 9d57d34a2791..0e844e0f5715 100644 --- a/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md +++ b/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md @@ -97,7 +97,7 @@ Maximum concurrency was measured using multiple repositories, job duration of ap {% note %} -**Note:** Beginning with {% data variables.product.prodname_ghe_server %} 3.6, {% data variables.product.company_short %} documents connected runners as opposed to concurrent jobs. Connected runners represents the most runners you can connect and expect to utilize. +**Note:** Beginning with {% data variables.product.prodname_ghe_server %} 3.6, {% data variables.product.company_short %} documents connected runners as opposed to concurrent jobs. Connected runners represents the most runners you can connect and expect to utilize. It should also be noted that connecting more runners than you can expect to utilize can negatively impact performance. {% endnote %} {% note %} From 3e63a04ef2111a9fb205c41059bc7dafe8d44305 Mon Sep 17 00:00:00 2001 From: Matt Pollard Date: Tue, 16 Aug 2022 17:56:03 +0200 Subject: [PATCH 7/7] Combine notes --- ...ted-with-github-actions-for-github-enterprise-server.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md b/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md index 0e844e0f5715..3eef9926ec25 100644 --- a/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md +++ b/content/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server.md @@ -97,12 +97,11 @@ Maximum concurrency was measured using multiple repositories, job duration of ap {% note %} -**Note:** Beginning with {% data variables.product.prodname_ghe_server %} 3.6, {% data variables.product.company_short %} documents connected runners as opposed to concurrent jobs. Connected runners represents the most runners you can connect and expect to utilize. It should also be noted that connecting more runners than you can expect to utilize can negatively impact performance. -{% endnote %} +**Notes:** -{% note %} +- Beginning with {% data variables.product.prodname_ghe_server %} 3.6, {% data variables.product.company_short %} documents connected runners as opposed to concurrent jobs. Connected runners represents the most runners you can connect and expect to utilize. It should also be noted that connecting more runners than you can expect to utilize can negatively impact performance. -**Note:** Beginning with {% data variables.product.prodname_ghe_server %} 3.5, {% data variables.product.company_short %}'s internal testing uses 3rd generation CPUs to better reflect a typical customer configuration. This change in CPU represents a small portion of the changes to performance targets in this version of {% data variables.product.prodname_ghe_server %}. +- Beginning with {% data variables.product.prodname_ghe_server %} 3.5, {% data variables.product.company_short %}'s internal testing uses 3rd generation CPUs to better reflect a typical customer configuration. This change in CPU represents a small portion of the changes to performance targets in this version of {% data variables.product.prodname_ghe_server %}. {% endnote %} {%- endif %}