feat: adding mentions about forking back after transferring repos #29193
Conversation
github-actions
bot
added
the
triage
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
|
Hi @cmwilson21! :) I made the PR. |
|
👋 Hey @CBID2! Thanks for the PR! I'll get it triaged ✨ |
cmwilson21
added
content
There was a problem hiding this comment.
Just a suggestion for improvement.
Note that I haven't verified whether what @stevecat wrote was the actual behavior. One thing strikes me as a little odd, which is that when I have previously renamed a repository, causing redirects to be created, and then overrode those redirects with a new repository, and then rename the repository again, I might actually want the redirects to be changed to point to the location of the second rename. But if the behavior is as described, the first redirects will always get re-activated and there is no (documented) way of changing the redirects.
| @@ -63,6 +63,8 @@ When you transfer a repository, its issues, pull requests, wiki, stars, and watc | |||
| {% endwarning %} | |||
|
|
|||
| - When you transfer a repository from an organization to a personal account, the repository's read-only collaborators will not be transferred. This is because collaborators can't have read-only access to repositories owned by a personal account. For more information about repository permission levels, see "[AUTOTITLE](/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-personal-account-settings/permission-levels-for-a-personal-account-repository)" and "[AUTOTITLE](/organizations/managing-user-access-to-your-organizations-repositories/managing-repository-roles/repository-roles-for-an-organization)."{% ifversion fpt or ghec %} | |||
| - Redirects will function until someone else creates a new repository or fork with the same name. | |||
| - Renaming or deleting the transferred repository or fork will reinstate the redirect. | |||
There was a problem hiding this comment.
I think it would be better to adjust the existing warning found earlier to reflect the actual behavior. Currently, it reads:
Warning: If you create a new repository under your account in the future, do not reuse the original name of the transferred repository. If you do, redirects to the transferred repository will no longer work.
Rather than repeating this information and adding another point about re-instantiation, the above text could just be changed to:
Warning: If you create a new repository at the previous repository location the redirects to the transferred repository will be deactivated. They can be reactivated by renaming or deleting the new repository.
There was a problem hiding this comment.
Hi @bjorn! :) Thanks for clarifying! :) I made the necessary change.
There was a problem hiding this comment.
Thank you for working on this, @CBID2! ✨ And a great suggestion from @bjorn.
I made one tiny suggested change, adding "or fork", and I'll apply that myself before merging.
The failing GraphQL test isn't anything to do with your changes, I suspect it'll pass when main is merged in as we deploy, but otherwise I'll troubleshoot this with the engineering team.
content/repositories/creating-and-managing-repositories/transferring-a-repository.md
Outdated
Show resolved
Hide resolved
…erring-a-repository.md
stevecat
added
hacktoberfest-accepted
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Boooo! 😞 This is an issue on our end, I've raised it with our engineering team and we'll get this merged as soon as we can! |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Per, @stevecat's recommendation, I added information more information about redirects. This helps owners of repositories gain more awareness about what could occur when they transfer ownership over their repos to other people.
Closes #13044
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
datadirectory.For content changes, I have completed the self-review checklist.