From 38c4f5772b2054e1bdd28ff12b0e64d6c55baef0 Mon Sep 17 00:00:00 2001 From: Sarita Iyer <66540150+saritai@users.noreply.github.com> Date: Thu, 29 Feb 2024 16:11:37 -0500 Subject: [PATCH 1/2] Remove links and mentions of OS Discussions (#49465) --- .github/workflows/close-bad-repo-sync-prs.yml | 2 +- README.md | 4 ---- .../about-contributing-to-github-docs.md | 18 +----------------- contributing/types-of-contributions.md | 7 +------ src/README.md | 2 +- 5 files changed, 4 insertions(+), 29 deletions(-) diff --git a/.github/workflows/close-bad-repo-sync-prs.yml b/.github/workflows/close-bad-repo-sync-prs.yml index 8919b5751d5d..493f259be3db 100644 --- a/.github/workflows/close-bad-repo-sync-prs.yml +++ b/.github/workflows/close-bad-repo-sync-prs.yml @@ -59,5 +59,5 @@ jobs: owner, repo, issue_number: prNumber, - body: "Please leave this `repo-sync` branch to the robots!\n\nI'm going to close this pull request now, but feel free to open a new issue or ask any questions in [discussions](https://github.com/github/docs/discussions)!" + body: "Please leave this `repo-sync` branch to the robots!\n\nI'm going to close this pull request now, but feel free to open a new issue in the repository!" }) diff --git a/README.md b/README.md index cb59748413ac..69090a601896 100644 --- a/README.md +++ b/README.md @@ -23,10 +23,6 @@ For more complex contributions, please open an issue using the most appropriate If you're looking for a way to contribute, you can scan through our [help wanted board](https://github.com/github/docs/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22) to find open issues already approved for work. -### Join us in discussions - -We use GitHub Discussions to talk about all sorts of topics related to documentation and this site. For example: if you'd like help troubleshooting a PR, have a great new idea, or want to share something amazing you've learned in our docs, join us in the [discussions](https://github.com/github/docs/discussions). - ### And that's it! If you're having trouble with your GitHub account, contact [Support](https://support.github.com). diff --git a/content/contributing/collaborating-on-github-docs/about-contributing-to-github-docs.md b/content/contributing/collaborating-on-github-docs/about-contributing-to-github-docs.md index f572a12fda42..28a3980dce4a 100644 --- a/content/contributing/collaborating-on-github-docs/about-contributing-to-github-docs.md +++ b/content/contributing/collaborating-on-github-docs/about-contributing-to-github-docs.md @@ -10,22 +10,6 @@ versions: The documentation repository is the place to discuss and collaborate on the documentation that is published here on [docs.github.com](/). -{% ifversion discussions %} - -## Discussions - -[Discussions](/discussions/quickstart) are where we have conversations. - -If you'd like help troubleshooting a documentation issue or pull request you're working on, have a great new idea for documentation, or want to share something amazing you've learned in our docs, join us in the [`docs` repository discussions](https://github.com/github/docs/discussions). - -{% note %} - -**Note**: To preserve the bandwidth of the Docs team, off-topic conversations will be closed. - -{% endnote %} - -{% endif %} - ## Issues [Issues](/github/managing-your-work-on-github/about-issues) are used to track tasks that contributors can help with. If an issue has a `triage` label, we haven't reviewed it yet, and you shouldn't begin work on it. @@ -62,7 +46,7 @@ For content changes, make sure that you: ## Support -We are a small team working hard to keep up with the documentation demands of a continuously changing product. Unfortunately, we just can't help with support questions in this repository. If you are experiencing a problem with {% data variables.product.prodname_dotcom %}, unrelated to our documentation, please [contact {% data variables.product.prodname_dotcom %} Support directly](https://support.github.com/contact). Any issues{% ifversion discussions %}, discussions,{% endif %} or pull requests opened in the documentation repository requesting support will be given information about how to contact {% data variables.product.prodname_dotcom %} Support, then closed and locked. +We are a small team working hard to keep up with the documentation demands of a continuously changing product. Unfortunately, we just can't help with support questions in this repository. If you are experiencing a problem with {% data variables.product.prodname_dotcom %}, unrelated to our documentation, please [contact {% data variables.product.prodname_dotcom %} Support directly](https://support.github.com/contact). Any issues or pull requests opened in the documentation repository requesting support will be given information about how to contact {% data variables.product.prodname_dotcom %} Support, then closed and locked. If you're having trouble with your {% data variables.product.prodname_dotcom %} account, contact [Support](https://support.github.com/contact?tags=docs-contributing-guide). diff --git a/contributing/types-of-contributions.md b/contributing/types-of-contributions.md index 132e6f652344..1d3ae178741f 100644 --- a/contributing/types-of-contributions.md +++ b/contributing/types-of-contributions.md @@ -1,11 +1,6 @@ # Types of contributions :memo: You can contribute to the GitHub Docs content and site in several ways. This repo is a place to discuss and collaborate on docs.github.com! Our small, but mighty :muscle: docs team is maintaining this repo; to preserve our bandwidth, off topic conversations will be closed. -### :mega: Discussions -Discussions are where we have conversations. - -If you'd like help troubleshooting a docs PR you're working on, have a great new idea, or want to share something amazing you've learned in our docs, join us in [discussions](https://github.com/github/docs/discussions). - ### :lady_beetle: Issues [Issues](https://docs.github.com/en/github/managing-your-work-on-github/about-issues) are used to track tasks that contributors can help with. If an issue has a triage label, we haven't reviewed it yet, and you shouldn't begin work on it. @@ -17,7 +12,7 @@ A [pull request](https://docs.github.com/en/github/collaborating-with-issues-and We cannot accept contributions to the [REST API reference documentation](https://docs.github.com/en/rest/reference). If you spot an inaccuracy in the REST API reference documentation, open an issue in the [github/rest-api-description](https://github.com/github/rest-api-description/issues/new?template=schema-inaccuracy.md) repository. ### :question: Support -We are a small team working hard to keep up with the documentation demands of a continuously changing product. Unfortunately, we just can't help with support questions in this repository. If you are experiencing a problem with GitHub, unrelated to our documentation, please [contact GitHub Support directly](https://support.github.com/contact). Any issues, discussions, or pull requests opened here requesting support will be given information about how to contact GitHub Support, then closed and locked. +We are a small team working hard to keep up with the documentation demands of a continuously changing product. Unfortunately, we just can't help with support questions in this repository. If you are experiencing a problem with GitHub, unrelated to our documentation, please [contact GitHub Support directly](https://support.github.com/contact). Any issues or pull requests opened here requesting support will be given information about how to contact GitHub Support, then closed and locked. If you're having trouble with your GitHub account, contact [Support](https://support.github.com/contact?tags=docs-contributing-guide). diff --git a/src/README.md b/src/README.md index d280736a094b..b9e6d514c25e 100644 --- a/src/README.md +++ b/src/README.md @@ -47,7 +47,7 @@ Check the README.md in the subject folder for questions specific to a subject. For internal folks, please ask in the Docs Engineering Slack or repository. -For open source folks, please ask on the [discussion board](https://github.com/github/docs/discussions). +For open source folks, please open an issue in the repository. ## A note on tests and required checks From 6a3d85578c26fca0a37bb3da32ce1c04b34f0d59 Mon Sep 17 00:00:00 2001 From: Collin McNeese Date: Thu, 29 Feb 2024 15:12:33 -0600 Subject: [PATCH 2/2] Update authenticating-to-the-github-api.md (#49431) Signed-off-by: Collin McNeese Co-authored-by: Siara <108543037+SiaraMist@users.noreply.github.com> --- .../authenticating-to-the-github-api.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/content/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/authenticating-to-the-github-api.md b/content/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/authenticating-to-the-github-api.md index d0e0477e1128..ff250014bc96 100644 --- a/content/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/authenticating-to-the-github-api.md +++ b/content/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/authenticating-to-the-github-api.md @@ -32,6 +32,11 @@ You can authenticate {% data variables.product.prodname_actions_runner_controlle 1. Under "Permissions," click **Repository permissions**. Then use the dropdown menus to select the following access permissions. - **Administration**: Read and write + {% note %} + + **Note**: `Administration: Read and write` is only required when configuring {% data variables.product.prodname_actions_runner_controller %} to register at the repository scope. It is not required to register at the organization scope. + + {% endnote %} - **Metadata**: Read-only 1. Under "Permissions," click **Organization permissions**. Then use the dropdown menus to select the following access permissions.