From 8c960d06a65e237b63028e777c31c576a33800b9 Mon Sep 17 00:00:00 2001 From: docs-bot <77750099+docs-bot@users.noreply.github.com> Date: Fri, 5 Sep 2025 09:38:46 -0700 Subject: [PATCH 1/2] GraphQL schema update (#57418) Co-authored-by: heiskr <1221423+heiskr@users.noreply.github.com> --- src/graphql/data/fpt/changelog.json | 18 +++++++++++++++++ .../fpt/graphql_upcoming_changes.public.yml | 16 +++++++-------- src/graphql/data/fpt/schema.docs.graphql | 2 +- src/graphql/data/fpt/upcoming-changes.json | 20 +++++++++---------- .../ghec/graphql_upcoming_changes.public.yml | 16 +++++++-------- src/graphql/data/ghec/schema.docs.graphql | 2 +- src/graphql/data/ghec/upcoming-changes.json | 20 +++++++++---------- 7 files changed, 56 insertions(+), 38 deletions(-) diff --git a/src/graphql/data/fpt/changelog.json b/src/graphql/data/fpt/changelog.json index 8caed3124ba0..33d4805ba016 100644 --- a/src/graphql/data/fpt/changelog.json +++ b/src/graphql/data/fpt/changelog.json @@ -1,4 +1,22 @@ [ + { + "schemaChanges": [ + { + "title": "The GraphQL schema includes these changes:", + "changes": [] + } + ], + "previewChanges": [], + "upcomingChanges": [ + { + "title": "The following changes will be made to the schema:", + "changes": [ + "

On member SearchType.ISSUE_ADVANCED:ISSUE_ADVANCED will be removed. Effective 2025-11-04.

" + ] + } + ], + "date": "2025-09-05" + }, { "schemaChanges": [ { diff --git a/src/graphql/data/fpt/graphql_upcoming_changes.public.yml b/src/graphql/data/fpt/graphql_upcoming_changes.public.yml index 6f13e8c4bafc..6e8148e1b4bc 100644 --- a/src/graphql/data/fpt/graphql_upcoming_changes.public.yml +++ b/src/graphql/data/fpt/graphql_upcoming_changes.public.yml @@ -1504,14 +1504,6 @@ upcoming_changes: date: '2025-04-01T00:00:00+00:00' criticality: breaking owner: github/memex - - location: SearchType.ISSUE_ADVANCED - description: '`ISSUE_ADVANCED` will be removed.' - reason: - Search for issues and pull requests will be overridden by advanced search - on September 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/. - date: '2025-09-04' - criticality: breaking - owner: github/issues_advanced_search - location: Issue.stateReason.enableDuplicate description: '`enableDuplicate` will be removed.' reason: The state reason for duplicate issue is now returned by default. @@ -1526,6 +1518,14 @@ upcoming_changes: date: '2025-10-01T00:00:00+00:00' criticality: breaking owner: github/advisory-database + - location: SearchType.ISSUE_ADVANCED + description: '`ISSUE_ADVANCED` will be removed.' + reason: + Search for issues and pull requests will be overridden by advanced search + on November 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/. + date: '2025-11-04' + criticality: breaking + owner: github/issues_advanced_search - location: NotificationThread.list description: '`list` will be removed. Use the `optionalList` field instead.' reason: Null values are possible for this field. diff --git a/src/graphql/data/fpt/schema.docs.graphql b/src/graphql/data/fpt/schema.docs.graphql index 35383076d9e1..e7929b2623dd 100644 --- a/src/graphql/data/fpt/schema.docs.graphql +++ b/src/graphql/data/fpt/schema.docs.graphql @@ -55192,7 +55192,7 @@ enum SearchType { """ ISSUE_ADVANCED @deprecated( - reason: "Search for issues and pull requests will be overridden by advanced search on September 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/. Removal on 2025-09-04 UTC." + reason: "Search for issues and pull requests will be overridden by advanced search on November 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/. Removal on 2025-11-04 UTC." ) """ diff --git a/src/graphql/data/fpt/upcoming-changes.json b/src/graphql/data/fpt/upcoming-changes.json index bbeb98409f6e..741b384cb168 100644 --- a/src/graphql/data/fpt/upcoming-changes.json +++ b/src/graphql/data/fpt/upcoming-changes.json @@ -8891,6 +8891,16 @@ "owner": "github/notifications" } ], + "2025-11-04": [ + { + "location": "SearchType.ISSUE_ADVANCED", + "description": "

ISSUE_ADVANCED will be removed.

", + "reason": "

Search for issues and pull requests will be overridden by advanced search on November 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/.

", + "date": "2025-11-04", + "criticality": "breaking", + "owner": "github/issues_advanced_search" + } + ], "2025-10-01": [ { "location": "SecurityAdvisory.cvss", @@ -8909,16 +8919,6 @@ "owner": "issues" } ], - "2025-09-04": [ - { - "location": "SearchType.ISSUE_ADVANCED", - "description": "

ISSUE_ADVANCED will be removed.

", - "reason": "

Search for issues and pull requests will be overridden by advanced search on September 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/.

", - "date": "2025-09-04", - "criticality": "breaking", - "owner": "github/issues_advanced_search" - } - ], "2025-04-01": [ { "location": "User.viewerCanCreateProjects", diff --git a/src/graphql/data/ghec/graphql_upcoming_changes.public.yml b/src/graphql/data/ghec/graphql_upcoming_changes.public.yml index 6f13e8c4bafc..6e8148e1b4bc 100644 --- a/src/graphql/data/ghec/graphql_upcoming_changes.public.yml +++ b/src/graphql/data/ghec/graphql_upcoming_changes.public.yml @@ -1504,14 +1504,6 @@ upcoming_changes: date: '2025-04-01T00:00:00+00:00' criticality: breaking owner: github/memex - - location: SearchType.ISSUE_ADVANCED - description: '`ISSUE_ADVANCED` will be removed.' - reason: - Search for issues and pull requests will be overridden by advanced search - on September 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/. - date: '2025-09-04' - criticality: breaking - owner: github/issues_advanced_search - location: Issue.stateReason.enableDuplicate description: '`enableDuplicate` will be removed.' reason: The state reason for duplicate issue is now returned by default. @@ -1526,6 +1518,14 @@ upcoming_changes: date: '2025-10-01T00:00:00+00:00' criticality: breaking owner: github/advisory-database + - location: SearchType.ISSUE_ADVANCED + description: '`ISSUE_ADVANCED` will be removed.' + reason: + Search for issues and pull requests will be overridden by advanced search + on November 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/. + date: '2025-11-04' + criticality: breaking + owner: github/issues_advanced_search - location: NotificationThread.list description: '`list` will be removed. Use the `optionalList` field instead.' reason: Null values are possible for this field. diff --git a/src/graphql/data/ghec/schema.docs.graphql b/src/graphql/data/ghec/schema.docs.graphql index 35383076d9e1..e7929b2623dd 100644 --- a/src/graphql/data/ghec/schema.docs.graphql +++ b/src/graphql/data/ghec/schema.docs.graphql @@ -55192,7 +55192,7 @@ enum SearchType { """ ISSUE_ADVANCED @deprecated( - reason: "Search for issues and pull requests will be overridden by advanced search on September 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/. Removal on 2025-09-04 UTC." + reason: "Search for issues and pull requests will be overridden by advanced search on November 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/. Removal on 2025-11-04 UTC." ) """ diff --git a/src/graphql/data/ghec/upcoming-changes.json b/src/graphql/data/ghec/upcoming-changes.json index bbeb98409f6e..741b384cb168 100644 --- a/src/graphql/data/ghec/upcoming-changes.json +++ b/src/graphql/data/ghec/upcoming-changes.json @@ -8891,6 +8891,16 @@ "owner": "github/notifications" } ], + "2025-11-04": [ + { + "location": "SearchType.ISSUE_ADVANCED", + "description": "

ISSUE_ADVANCED will be removed.

", + "reason": "

Search for issues and pull requests will be overridden by advanced search on November 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/.

", + "date": "2025-11-04", + "criticality": "breaking", + "owner": "github/issues_advanced_search" + } + ], "2025-10-01": [ { "location": "SecurityAdvisory.cvss", @@ -8909,16 +8919,6 @@ "owner": "issues" } ], - "2025-09-04": [ - { - "location": "SearchType.ISSUE_ADVANCED", - "description": "

ISSUE_ADVANCED will be removed.

", - "reason": "

Search for issues and pull requests will be overridden by advanced search on September 4, 2025. You can read more about this change on https://github.blog/changelog/2025-03-06-github-issues-projects-api-support-for-issues-advanced-search-and-more/.

", - "date": "2025-09-04", - "criticality": "breaking", - "owner": "github/issues_advanced_search" - } - ], "2025-04-01": [ { "location": "User.viewerCanCreateProjects", From 0df7c296c8ea7e7ec974939a378d2ee9b29e31e2 Mon Sep 17 00:00:00 2001 From: Pallavi <96553709+pallsama@users.noreply.github.com> Date: Fri, 5 Sep 2025 09:55:47 -0700 Subject: [PATCH 2/2] Updating new end of support dates for GHES 3.14, 3.15, 3.16 and 3.17. (#57409) Co-authored-by: Vanessa Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com> --- src/archives/tests/deprecated-enterprise-versions.ts | 6 ++---- src/ghes-releases/lib/enterprise-dates.json | 12 ++++++------ src/versions/components/DeprecationBanner.tsx | 10 ---------- 3 files changed, 8 insertions(+), 20 deletions(-) diff --git a/src/archives/tests/deprecated-enterprise-versions.ts b/src/archives/tests/deprecated-enterprise-versions.ts index c1274b6e2021..3515fb7bb587 100644 --- a/src/archives/tests/deprecated-enterprise-versions.ts +++ b/src/archives/tests/deprecated-enterprise-versions.ts @@ -138,8 +138,7 @@ describe('recently deprecated redirects', () => { }) describe('deprecation banner', () => { - // The deprecation banner is temporarily hidden for supported versions - test.skip('renders a deprecation warning banner on oldest supported Enterprise version', async () => { + test('renders a deprecation warning banner on oldest supported Enterprise version', async () => { const { $ } = await getDOM(`/en/enterprise/${enterpriseServerReleases.oldestSupported}`) expect($('[data-testid=deprecation-banner]').length).toBe(1) }) @@ -154,8 +153,7 @@ describe('deprecation banner', () => { expect($('[data-testid=deprecation-banner] b').text().endsWith('discontinued on .')).toBe(false) }) - // The deprecation banner is temporarily hidden for supported versions - test.skip('deprecation warning banner includes the right text depending on the date', async () => { + test('deprecation warning banner includes the right text depending on the date', async () => { const { $ } = await getDOM(`/en/enterprise/${enterpriseServerReleases.oldestSupported}`) const expectedString = enterpriseServerReleases.isOldestReleaseDeprecated ? 'was discontinued' diff --git a/src/ghes-releases/lib/enterprise-dates.json b/src/ghes-releases/lib/enterprise-dates.json index 0c014cc79155..d45bc146f360 100644 --- a/src/ghes-releases/lib/enterprise-dates.json +++ b/src/ghes-releases/lib/enterprise-dates.json @@ -229,31 +229,31 @@ }, "3.14": { "releaseDate": "2024-08-06", - "deprecationDate": "2025-08-27", + "deprecationDate": "2026-03-17", "releaseCandidateDate": "2024-08-06", "generalAvailabilityDate": "2024-08-27" }, "3.15": { "releaseDate": "2024-11-12", - "deprecationDate": "2025-12-19", + "deprecationDate": "2026-03-17", "releaseCandidateDate": "2024-11-12", "generalAvailabilityDate": "2024-12-03" }, "3.16": { "releaseDate": "2025-02-25", - "deprecationDate": "2026-03-11", + "deprecationDate": "2026-06-02", "releaseCandidateDate": "2025-02-25", "generalAvailabilityDate": "2025-03-11" }, "3.17": { "releaseDate": "2025-05-13", - "deprecationDate": "2026-06-03", + "deprecationDate": "2026-08-25", "releaseCandidateDate": "2025-05-13", "generalAvailabilityDate": "2025-06-03" }, "3.18": { "releaseDate": "2025-08-05", - "deprecationDate": "2026-08-26", + "deprecationDate": "2026-08-25", "releaseCandidateDate": "2025-08-05", "generalAvailabilityDate": "2025-08-26" }, @@ -287,4 +287,4 @@ "releaseCandidateDate": "2026-11-10", "generalAvailabilityDate": "2026-12-08" } -} \ No newline at end of file +} diff --git a/src/versions/components/DeprecationBanner.tsx b/src/versions/components/DeprecationBanner.tsx index f80475fd2be3..ed989fb15344 100644 --- a/src/versions/components/DeprecationBanner.tsx +++ b/src/versions/components/DeprecationBanner.tsx @@ -6,12 +6,6 @@ import cx from 'classnames' import styles from './DeprecationBanner.module.scss' -// GHES deprecation dates are being extended while -// performance issues are being addressed in versions >= 3.15. -// This banner should remain hidden for the supported versions (>=3.14) until -// new deprecation dates are announced. -const DEPRECATION_BANNER_EXCEPTIONS = ['3.14'] - export const DeprecationBanner = () => { const { data, enterpriseServerReleases } = useMainContext() const { currentVersion } = useVersion() @@ -29,10 +23,6 @@ export const DeprecationBanner = () => { ? enterpriseDeprecation.version_was_deprecated : enterpriseDeprecation.version_will_be_deprecated - if (DEPRECATION_BANNER_EXCEPTIONS.some((version) => currentVersion.includes(version))) { - return null - } - return (