From 0a38491c97b27a66cbb62aea29b8fd27444b0330 Mon Sep 17 00:00:00 2001 From: Robert Sese <734194+rsese@users.noreply.github.com> Date: Tue, 21 Oct 2025 17:28:36 -0500 Subject: [PATCH 1/2] journey landing page tests tweaks (#58097) --- .../content/get-started/carousel/index.md | 4 ++-- .../fixtures/content/get-started/index.md | 1 + .../{ => get-started}/test-journey/index.md | 2 +- src/fixtures/fixtures/content/index.md | 1 - src/fixtures/tests/playwright-rendering.spec.ts | 16 ++++++++-------- 5 files changed, 12 insertions(+), 12 deletions(-) rename src/fixtures/fixtures/content/{ => get-started}/test-journey/index.md (95%) diff --git a/src/fixtures/fixtures/content/get-started/carousel/index.md b/src/fixtures/fixtures/content/get-started/carousel/index.md index a406feb1d91d..e31cabbfba67 100644 --- a/src/fixtures/fixtures/content/get-started/carousel/index.md +++ b/src/fixtures/fixtures/content/get-started/carousel/index.md @@ -1,11 +1,11 @@ --- -title: Carousel Test Category +title: Landing Page Carousel intro: 'A test category page for testing the LandingCarousel component.' versions: fpt: '*' ghes: '*' ghec: '*' -layout: category-landing +layout: discovery-landing recommended: - /category-one/article-one - /category-one/article-two diff --git a/src/fixtures/fixtures/content/get-started/index.md b/src/fixtures/fixtures/content/get-started/index.md index c96cdc006024..f49326331f7e 100644 --- a/src/fixtures/fixtures/content/get-started/index.md +++ b/src/fixtures/fixtures/content/get-started/index.md @@ -41,6 +41,7 @@ children: - /versioning - /learning-about-github - /empty-categories + - /test-journey - /carousel - /article-grid-discovery - /article-grid-bespoke diff --git a/src/fixtures/fixtures/content/test-journey/index.md b/src/fixtures/fixtures/content/get-started/test-journey/index.md similarity index 95% rename from src/fixtures/fixtures/content/test-journey/index.md rename to src/fixtures/fixtures/content/get-started/test-journey/index.md index 364e1d2880b7..1b30f95696ac 100644 --- a/src/fixtures/fixtures/content/test-journey/index.md +++ b/src/fixtures/fixtures/content/get-started/test-journey/index.md @@ -1,5 +1,5 @@ --- -title: Test Journey Landing +title: Journey Landing intro: 'Test page for journey tracks functionality' layout: journey-landing versions: diff --git a/src/fixtures/fixtures/content/index.md b/src/fixtures/fixtures/content/index.md index d13e6dd64985..e3b95a0713d8 100644 --- a/src/fixtures/fixtures/content/index.md +++ b/src/fixtures/fixtures/content/index.md @@ -26,7 +26,6 @@ children: # as if the URL had been `/en/free-pro-team@latest/get-started/anything`. - search - get-started - - test-journey - early-access - pages - code-security diff --git a/src/fixtures/tests/playwright-rendering.spec.ts b/src/fixtures/tests/playwright-rendering.spec.ts index 16b90f4c9fd6..17776def96ac 100644 --- a/src/fixtures/tests/playwright-rendering.spec.ts +++ b/src/fixtures/tests/playwright-rendering.spec.ts @@ -1008,7 +1008,7 @@ test('open search, Ask AI returns 400 error and shows general search results', a test.describe('LandingCarousel component', () => { test('displays carousel on test page', async ({ page }) => { - await page.goto('/get-started/carousel?feature=discovery-landing') + await page.goto('/get-started/carousel') const carousel = page.locator('[data-testid="landing-carousel"]') await expect(carousel).toBeVisible() @@ -1026,7 +1026,7 @@ test.describe('LandingCarousel component', () => { test('navigation works on desktop', async ({ page }) => { await page.setViewportSize({ width: 1200, height: 800 }) - await page.goto('/get-started/carousel?feature=discovery-landing') + await page.goto('/get-started/carousel') const carousel = page.locator('[data-testid="landing-carousel"]') await expect(carousel).toBeVisible() @@ -1046,7 +1046,7 @@ test.describe('LandingCarousel component', () => { test('responsive behavior on mobile', async ({ page }) => { await page.setViewportSize({ width: 375, height: 667 }) - await page.goto('/get-started/carousel?feature=discovery-landing') + await page.goto('/get-started/carousel') const carousel = page.locator('[data-testid="landing-carousel"]') await expect(carousel).toBeVisible() @@ -1059,7 +1059,7 @@ test.describe('LandingCarousel component', () => { test.describe('Journey Tracks', () => { test('displays journey tracks on landing pages', async ({ page }) => { - await page.goto('/get-started?feature=journey-landing') + await page.goto('/get-started/test-journey') const journeyTracks = page.locator('[data-testid="journey-tracks"]') await expect(journeyTracks).toBeVisible() @@ -1075,7 +1075,7 @@ test.describe('Journey Tracks', () => { }) test('track expansion and collapse functionality', async ({ page }) => { - await page.goto('/get-started?feature=journey-landing') + await page.goto('/get-started/test-journey') const firstTrack = page.locator('[data-testid="journey-track"]').first() const expandButton = firstTrack.locator('summary') @@ -1095,7 +1095,7 @@ test.describe('Journey Tracks', () => { }) test('article navigation within tracks', async ({ page }) => { - await page.goto('/get-started?feature=journey-landing') + await page.goto('/get-started/test-journey') const firstTrack = page.locator('[data-testid="journey-track"]').first() const expandButton = firstTrack.locator('summary') @@ -1112,7 +1112,7 @@ test.describe('Journey Tracks', () => { }) test('preserves version in journey track links', async ({ page }) => { - await page.goto('/enterprise-cloud@latest/get-started?feature=journey-landing') + await page.goto('/enterprise-cloud@latest/get-started/test-journey') const firstTrack = page.locator('[data-testid="journey-track"]').first() const expandButton = firstTrack.locator('summary') @@ -1127,7 +1127,7 @@ test.describe('Journey Tracks', () => { }) test('handles liquid template rendering in track content', async ({ page }) => { - await page.goto('/get-started?feature=journey-landing') + await page.goto('/get-started/test-journey') const tracks = page.locator('[data-testid="journey-track"]') From 35cc37cc4cc5df4d10037267fb9c7972129ef843 Mon Sep 17 00:00:00 2001 From: Tomoko Tanaka <28242405+tallzeebaa@users.noreply.github.com> Date: Wed, 22 Oct 2025 09:41:18 +1100 Subject: [PATCH 2/2] Clarified the conditions under which IP addresses are displayed in the audit log for `api.request` events. (#58083) --- ...aying-ip-addresses-in-the-audit-log-for-your-enterprise.md | 2 +- ...ing-ip-addresses-in-the-audit-log-for-your-organization.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/content/admin/monitoring-activity-in-your-enterprise/reviewing-audit-logs-for-your-enterprise/displaying-ip-addresses-in-the-audit-log-for-your-enterprise.md b/content/admin/monitoring-activity-in-your-enterprise/reviewing-audit-logs-for-your-enterprise/displaying-ip-addresses-in-the-audit-log-for-your-enterprise.md index 91b11e5896e6..c652ad0983bc 100644 --- a/content/admin/monitoring-activity-in-your-enterprise/reviewing-audit-logs-for-your-enterprise/displaying-ip-addresses-in-the-audit-log-for-your-enterprise.md +++ b/content/admin/monitoring-activity-in-your-enterprise/reviewing-audit-logs-for-your-enterprise/displaying-ip-addresses-in-the-audit-log-for-your-enterprise.md @@ -36,7 +36,7 @@ If members of your enterprise access {% data variables.location.product_location * Interactions with a resource owned by the personal account, including a repository, gist, or project * Interactions with a public repository owned by an organization in your enterprise -{% data variables.product.github %} does not display IP address in the audit log for `api.request` events triggered by GraphQL requests. +{% data variables.product.github %} does not display IP addresses in the audit log for `api.request` events that do not have repository context, such as requests triggered by GraphQL or requests to endpoints that reference only a user or organization. ## Enabling display of IP addresses in the audit log diff --git a/content/organizations/keeping-your-organization-secure/managing-security-settings-for-your-organization/displaying-ip-addresses-in-the-audit-log-for-your-organization.md b/content/organizations/keeping-your-organization-secure/managing-security-settings-for-your-organization/displaying-ip-addresses-in-the-audit-log-for-your-organization.md index 1d00e33871c3..0446379c1683 100644 --- a/content/organizations/keeping-your-organization-secure/managing-security-settings-for-your-organization/displaying-ip-addresses-in-the-audit-log-for-your-organization.md +++ b/content/organizations/keeping-your-organization-secure/managing-security-settings-for-your-organization/displaying-ip-addresses-in-the-audit-log-for-your-organization.md @@ -36,9 +36,9 @@ After you enable the feature, you can access the audit log to view events that i {% data variables.product.github %} displays an IP address for each event in the organization audit log that meets these criteria. -* The actor is an organization member or owner +* The actor is an organization member or owner. * The target is either an organization-owned repository that is private or internal, or an organization resource that is not a repository, such as a project. -* For `api.request` events, the request was not triggered by GraphQL. +* For `api.request` events, the request must have repository context; requests triggered by GraphQL or to endpoints that reference only a user or organization do not meet this condition. ## Enabling display of IP addresses in the audit log