Major fixture #5538
Major fixture #5538
Conversation
What is been changed?
- The following instances:
{% data reusables.profile.access_profile %}
{% data reusables.profile.access_org %}
{% data reusables.organizations.org_settings %}
Is replaced with:
{% data reusables.profile.access_org %}
{% data reusables.organizations.org_settings %}
What changes have been made? - Created a org_settings.md file and added one statement.
github-actions
bot
added
the
triage
|
👏 👏 👏 Thanks so much for finding all these changes @StarTrooper08 🎉 🎉 🎉 I'll get this up for review! In the meantime, can you update your comment above ☝️ to use the pull request template? Having a consistent format makes it a lot easier for writers to get all the context they need when they come in to review. Thanks! |
janiceilene
added
core
waiting for review
|
Is the above comment is right now?? |
|
Can you enable the checkbox to allow maintainer edits? Then I'll be able to make some quick fixes and get this merged in. Thank you! https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork |
|
@lee-dohm pardon but I didn't get the point. |
|
The checkbox to allow the 'Allow edits and access to secrets by maintainers' is been selected. Should I uncheck it?? |
|
No, please leave it checked. I'll try pushing my changes to your PR again. |
ethanpalm
left a comment
ethanpalm
left a comment
There was a problem hiding this comment.
Hi @StarTrooper08! Thanks so much for taking the time to make all of these changes ✨
I've opened a PR to go with yours that makes a few more changes. This PR, #5732, updates images in the reusables and makes some adjustments to how the user interface elements are written. If you have any questions about it, please let me know.
Thanks again for helping to improve the GitHub docs. Please see the help wanted issues if you would like to contribute on another project.
The changes in your PR will be live on the docs.github.com site within 24 hours 😁 🎉
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
4 participants
Why:
Closes [issue link]
What's being changed:
Check off the following:
Changes made as mentioned :
#2919 (comment)
I have reviewed the code and making the PR for the same . Please have a review from your side
The changes made will closed the issue no. #2919.