Update NoAriaLabelMisuse rule documentation
#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolonio
reviewed
Feb 1, 2022
| ### "Help! I'm trying to set a tooltip on a static element and this rule flagged it!" | ||
|
|
||
| Learn more at [W3C Name Calcluation](https://w3c.github.io/aria/#namecalculation). | ||
| Please do not use tooltips on static elements. It is a highly discouraged, inaccessible pattern for the following reasons: |
There was a problem hiding this comment.
Do we want to include the source from where the reasons are coming?
Collaborator
Author
There was a problem hiding this comment.
I added a source in line 20 :)
bolonio
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
NoAriaLabelMisusedocumentation to be more informative on why this is a discouarged pattern, and addresses violations that involve a tooltip. This also adds better examples of correct usage.