Convert NoAriaLabelMisuse to counter
#21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khiga8
force-pushed
the
kh-convert-aria-label-misuse-to-counter
branch
from
3c67a14 to
83f6534
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #19. e953e0b should be removed once the PR 19 has merged..
Closes #20
This PR converts
NoAriaLabelMisuseto a counter so that when people introduce violations to a file, they need to bump the count. In dotcom, this rule is the most common linter violation and we've needed to add a bunch of file-level disables. Let's convert this to a counter so this rule isn't ignored.