Skip to content

Conversation

@khiga8
Copy link
Collaborator

@khiga8 khiga8 commented Sep 2, 2022

Fixes: #48

What?

Sorry for the big diff! It comes from the file renames and adding a couple of the same tests.

This completes migration of the remaining 5 non-counter rules:

  • Swaps rule_disabled? code with counter_correct? code
  • Add autocorrect support.
  • Add counter test cases to existing test.
  • Rename rules to include counter.

Why?

Counters have better disable functionality. These remaining 5 rules are in "legacy" format and I think it'll be confusing for new people trying to introduce this plugin to their project that we have a erblint:disable format and an erblint:counter format.

I am trying to complete this migration to better enable one of our teams who are in the process of enabling this plugin in their repo :).

With these changes, a codebase newly enabling this plugin can run:

bundle exec erblint app/views -a

to add the disable comments wherever necessary.

@khiga8 khiga8 requested a review from bolonio September 2, 2022 23:15
@khiga8 khiga8 marked this pull request as ready for review September 2, 2022 23:16
@khiga8 khiga8 requested a review from a team as a code owner September 2, 2022 23:16
@khiga8 khiga8 requested a review from lindseywild September 2, 2022 23:16
@accessibility-bot
Copy link

👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.

  • 💻 On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
  • ⚠️ If this is urgent, please visit us in #accessibility on Slack and tag the first responder(s) listed in the channel topic.

@bolonio bolonio merged commit 90ecbf1 into main Sep 5, 2022
@bolonio bolonio deleted the kh-migrate-to-counters-1 branch September 5, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert remaining rules to counters

4 participants