Migrate remaining non-counter rules to counters #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #48
What?
Sorry for the big diff! It comes from the file renames and adding a couple of the same tests.
This completes migration of the remaining 5 non-counter rules:
rule_disabled?code withcounter_correct?codecounter.Why?
Counters have better disable functionality. These remaining 5 rules are in "legacy" format and I think it'll be confusing for new people trying to introduce this plugin to their project that we have a
erblint:disableformat and anerblint:counterformat.I am trying to complete this migration to better enable one of our teams who are in the process of enabling this plugin in their repo :).
With these changes, a codebase newly enabling this plugin can run:
to add the disable comments wherever necessary.