From 3c06626099de1b076211b8e276271ef9dbd2986c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Oddsson?= Date: Mon, 9 Mar 2020 14:09:07 +0000 Subject: [PATCH] remove node config --- bin/eslint-github-init.js | 6 ++---- docs/configs.md | 4 ---- lib/configs/node.js | 11 ----------- lib/index.js | 1 - package.json | 3 --- 5 files changed, 2 insertions(+), 23 deletions(-) delete mode 100644 lib/configs/node.js diff --git a/bin/eslint-github-init.js b/bin/eslint-github-init.js index cd7f9d71..7300b273 100755 --- a/bin/eslint-github-init.js +++ b/bin/eslint-github-init.js @@ -35,7 +35,7 @@ const questions = [ type: 'list', name: 'env', message: 'Which environment does this library target?', - choices: ['browser', 'node'], + choices: ['browser'], default: defaults.env }, { @@ -50,9 +50,7 @@ const questions = [ inquirer.prompt(questions).then(answers => { const eslintrc = {extends: ['plugin:github/es6']} - if (answers.env === 'node') { - eslintrc.extends.push('plugin:github/node') - } else if (answers.project === 'app') { + if (answers.project === 'app') { eslintrc.extends.push('plugin:github/app') } else if (answers.env === 'browser') { eslintrc.extends.push('plugin:github/browser') diff --git a/docs/configs.md b/docs/configs.md index 036a7c7c..19ba9353 100644 --- a/docs/configs.md +++ b/docs/configs.md @@ -29,7 +29,3 @@ Recommended rules when using Babel to transpile features from ES2015+. ### `plugin:github/app` Recommended rules when writing a browser application. - -### `plugin:github/node` - -Recommended rules when writing a node application. diff --git a/lib/configs/node.js b/lib/configs/node.js deleted file mode 100644 index 637faa77..00000000 --- a/lib/configs/node.js +++ /dev/null @@ -1,11 +0,0 @@ -module.exports = { - parser: 'babel-eslint', - env: { - node: true - }, - plugins: ['github'], - rules: { - 'no-console': 'off' - }, - extends: [require.resolve('./recommended')] -} diff --git a/lib/index.js b/lib/index.js index 77994b62..a9e4139f 100644 --- a/lib/index.js +++ b/lib/index.js @@ -21,7 +21,6 @@ module.exports = { app: require('./configs/app'), browser: require('./configs/browser'), es6: require('./configs/es6'), - node: require('./configs/node'), recommended: require('./configs/recommended'), typescript: require('./configs/typescript') } diff --git a/package.json b/package.json index 156538bb..92a571df 100644 --- a/package.json +++ b/package.json @@ -28,9 +28,6 @@ "url": "https://github.com/github/eslint-plugin-github/issues" }, "homepage": "https://github.com/github/eslint-plugin-github#readme", - "engines": { - "node": ">=8.11.1" - }, "dependencies": { "@typescript-eslint/eslint-plugin": ">=2.5.0", "@typescript-eslint/parser": ">=2.5.0",