This repository was archived by the owner on Aug 3, 2020. It is now read-only.
Add EventListener interface support - #13
Merged
Merged
Conversation
5 tasks
keithamus
reviewed
May 6, 2019
keithamus
left a comment
keithamus
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your work on this @javan! I agree we should definitely get this fixed, but I've left a comment to ensure we fix it in a way which is most compatible with existing browser behaviour. If you could take a look at the review comment, and perhaps add some tests to verify that, then I'll happily merge this in and cut a new patch release!
keithamus
approved these changes
May 7, 2019
Contributor
|
@javan I've released this as 1.0.5 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10