Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EventListener interface support #13

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
2 participants

@javan javan referenced this pull request May 3, 2019

Open

Introduce once and passive events to actions #232

5 of 5 tasks complete

@muan muan requested a review from github/web-systems-reviewers May 3, 2019

@dgraham dgraham requested a review from keithamus May 6, 2019

@keithamus
Copy link
Member

left a comment

Thanks for your work on this @javan! I agree we should definitely get this fixed, but I've left a comment to ensure we fix it in a way which is most compatible with existing browser behaviour. If you could take a look at the review comment, and perhaps add some tests to verify that, then I'll happily merge this in and cut a new patch release!

Show resolved Hide resolved src/index.js Outdated

@keithamus keithamus merged commit 6ea02e7 into github:master May 7, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@keithamus

This comment has been minimized.

Copy link
Member

commented May 7, 2019

@javan I've released this as 1.0.5 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.