-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Fix a couple things with spacevim, nim topics #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@cheshire137 |
|
nice,:) |
|
@data-man, I just pulled in the changes for nim, you can see them at https://github.com/topics/nim. That's when I noticed the missing "language" and the other things I changed. Those changes should be live shortly, once I merge this PR. 🎉 Thanks for the quick reviews! |
|
@cheshire137 |
Ahh, that list is a subset of all the topics that are in this repository. I think we've not been adding topics to that list unless they have about 500 repositories using them. |
|
I could be wrong, but I think Nim has more than 500 repositories. :-) |
Hmm, I'm seeing a little under 400, looking at https://github.com/topics/nim + https://github.com/topics/nim-lang + https://github.com/topics/nim-language + https://github.com/topics/nimlang. |
|
https://github.com/search?l=Nim&q=nim&type=Repositories give me 1,345 results |
|
Thanks for the link! The /topics page displays topics based on how many repositories have explicitly applied them as a topic. The page giving you 1.3k results is based on the language detected for the repositories, not which topics are applied. https://github.com/search?utf8=%E2%9C%93&q=topic%3Anim&type=Repositories is closer to what the /topics/nim page displays. |
|
I'm sorry, but I think this is wrong. |
|
That's a really interesting problem, @data-man. Makes me wonder if we should consider auto-assigning the respective language-named topics to repos that dynamically identify their language. |
I wanted to suggest the same thing. :-) |
|
Thanks for your feedback. The goal of the Topics page is to help more people discover topics that have been applied to repositories. If you've noticed that not enough people are using the |
In our Gitter channel we did so. |
|
I think It should be managered by repo admin himself, People who want to support a topic, He will add the topic himself. and topic is difference from language, A language contains many topic, and different language also may has same topic. |
|
I think the tension here is that a "topic" on GitHub can be interpreted (understandably) broadly as a "keyword" for which repos, users, and other things are "results." Instead, we're asking folks to intuit that a "topic" on GitHub is a "tag" for which repos (the only entity GitHub currently associates with topics) must be actively "tagged" with. That's some tension we (namely, us folks designing the Explore experience) are going to have to address in short order. |
This makes a couple small fixes to two existing topics:
A couple grammar fixes for nim. /cc @data-man
Fixes unintentional wrapping in the spacevim body from newlines being rendered as
<br>tags. See before:/cc @wsdjeg