Skip to content

Conversation

cheshire137
Copy link
Member

This makes a couple small fixes to two existing topics:

  • A couple grammar fixes for nim. /cc @data-man

  • Fixes unintentional wrapping in the spacevim body from newlines being rendered as <br> tags. See before:

    topic__spacevim

    /cc @wsdjeg

@data-man
Copy link
Contributor

data-man commented Jan 3, 2018

@cheshire137
Thanks!
When Nim will be in the topics? :-)

@wsdjeg
Copy link
Contributor

wsdjeg commented Jan 3, 2018

nice,:)

@cheshire137
Copy link
Member Author

@data-man, I just pulled in the changes for nim, you can see them at https://github.com/topics/nim. That's when I noticed the missing "language" and the other things I changed. Those changes should be live shortly, once I merge this PR. 🎉

Thanks for the quick reviews!

@cheshire137 cheshire137 merged commit 533e298 into master Jan 3, 2018
@cheshire137 cheshire137 deleted the fix-body-wrapping branch January 3, 2018 22:03
@data-man
Copy link
Contributor

data-man commented Jan 3, 2018

@cheshire137
I mean the list of topics https://github.com/topics

@cheshire137
Copy link
Member Author

the list of topics

Ahh, that list is a subset of all the topics that are in this repository. I think we've not been adding topics to that list unless they have about 500 repositories using them.

@data-man
Copy link
Contributor

data-man commented Jan 3, 2018

I could be wrong, but I think Nim has more than 500 repositories. :-)

@cheshire137
Copy link
Member Author

I think Nim has more than 500

Hmm, I'm seeing a little under 400, looking at https://github.com/topics/nim + https://github.com/topics/nim-lang + https://github.com/topics/nim-language + https://github.com/topics/nimlang.

@data-man
Copy link
Contributor

data-man commented Jan 3, 2018

https://github.com/search?l=Nim&q=nim&type=Repositories give me 1,345 results

@cheshire137
Copy link
Member Author

Thanks for the link! The /topics page displays topics based on how many repositories have explicitly applied them as a topic. The page giving you 1.3k results is based on the language detected for the repositories, not which topics are applied. https://github.com/search?utf8=%E2%9C%93&q=topic%3Anim&type=Repositories is closer to what the /topics/nim page displays.

@data-man
Copy link
Contributor

data-man commented Jan 4, 2018

I'm sorry, but I think this is wrong.
This means that the results for all languages are incorrect.
Many new github users just don't think (or don't know) about assigning a topic.

@brandonrosage
Copy link
Contributor

That's a really interesting problem, @data-man. Makes me wonder if we should consider auto-assigning the respective language-named topics to repos that dynamically identify their language.

@data-man
Copy link
Contributor

data-man commented Jan 4, 2018

@brandonrosage

we should consider auto-assigning the respective language-named topics to repos that dynamically identify their language.

I wanted to suggest the same thing. :-)

@cheshire137
Copy link
Member Author

Thanks for your feedback. The goal of the Topics page is to help more people discover topics that have been applied to repositories. If you've noticed that not enough people are using the nim topic, you may want to let them know about it!

@data-man
Copy link
Contributor

data-man commented Jan 4, 2018

@cheshire137

you may want to let them know about it!

In our Gitter channel we did so.
But the problem is that very few people using this system for communication.
We invite you!
If I were closer, I'd invite you for a glass of tea. The Earl Grey, of course. :-)

@wsdjeg
Copy link
Contributor

wsdjeg commented Jan 4, 2018

I think It should be managered by repo admin himself, People who want to support a topic, He will add the topic himself. and topic is difference from language, A language contains many topic, and different language also may has same topic.

@brandonrosage
Copy link
Contributor

I think the tension here is that a "topic" on GitHub can be interpreted (understandably) broadly as a "keyword" for which repos, users, and other things are "results."

Instead, we're asking folks to intuit that a "topic" on GitHub is a "tag" for which repos (the only entity GitHub currently associates with topics) must be actively "tagged" with.

That's some tension we (namely, us folks designing the Explore experience) are going to have to address in short order.

@cheshire137 cheshire137 mentioned this pull request Jan 10, 2018
6 tasks
@cheshire137 cheshire137 mentioned this pull request Feb 9, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants