Add Maven Topic #187
Merged
Add Maven Topic #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
approved these changes
Feb 28, 2018
Contributor
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
One question otherwise 👍
topics/maven/index.md
Outdated
| --- | ||
| aliases: apache-maven | ||
| created_by: Apache Software Foundation | ||
| display_name: "Maven" |
Contributor
There was a problem hiding this comment.
Does this need the quotes?
topics/maven/index.md
Outdated
| github_url: https://github.com/apache/maven | ||
| logo: maven.png | ||
| released: July 13, 2004 | ||
| short_description: "Maven is a build automation tool used primarily for Java projects." |
Contributor
There was a problem hiding this comment.
Does this need the quotes?
Contributor
Author
There was a problem hiding this comment.
Good catch on these, it shouldn't need the quotes. Updated!
MikeMcQuaid
approved these changes
Mar 1, 2018
Contributor
|
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @RohanNagar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am:
EDITING AN EXISTING TOPIC OR COLLECTION*
I'm suggesting these edits to an existing topic or collection:
*.png, square, dimensions 288x288)index.md)Please explain why these changes are necessary:
CURATING A NEW TOPIC
https://github.com/topics/[NAME])*.pngimage (if applicable) andindex.mdindex.mdconform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docsPlease explain why you think this topic should be curated:
Maven is a popular tool among Java developers and is often searched for. Having a description of this topic as links to more documentation will help developers searching for it on GitHub for the first time.
CURATING A NEW COLLECTION
https://github.com/collections/[NAME])*.pngimage (if applicable) andindex.mdindex.mdconform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docsPlease explain why you think this collection should be curated:
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.