Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Racket topic #522

Merged
merged 3 commits into from Jan 16, 2019

Conversation

Projects
None yet
2 participants
@spdegabrielle
Copy link
Contributor

commented Jan 16, 2019

Thank you for contributing! Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288)
  • Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Racket is a growing programming language with over 6K repositories on github https://github.com/search?q=language%3Aracket


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

spdegabrielle added some commits Jan 16, 2019

@MikeMcQuaid MikeMcQuaid changed the title Patch 1 Add Racket topic Jan 16, 2019

@MikeMcQuaid

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2019

Test failure:

topic images should be 288px wide.
Expected: 288
Actual: 200

@spdegabrielle

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2019

updated image to eb 288X288

@spdegabrielle

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2019

@MikeMcQuaid thanks for fixing the PR title and letting me know about the image. I have updated the image and the checks have passed.

@MikeMcQuaid
Copy link
Contributor

left a comment

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @spdegabrielle!

@MikeMcQuaid MikeMcQuaid merged commit 01e5de6 into github:master Jan 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@spdegabrielle spdegabrielle deleted the spdegabrielle:patch-1 branch Jan 16, 2019

@spdegabrielle spdegabrielle restored the spdegabrielle:patch-1 branch Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.