Refactor COPILOT_MODEL resolution to remove duplicated env precedence logic

[Copilot]

src/services/api-proxy-service.ts had two near-identical helpers implementing the same env precedence (additionalEnv ?? envFile ?? process.env) for COPILOT_MODEL. This created avoidable drift risk for future precedence changes.

• Consolidation

  • Removed getCopilotModel(config) (duplicate implementation).
  • Kept getConfigEnvValue(config, key) as the single source of truth for config/env resolution.

• Call site update

  • Replaced the only getCopilotModel usage in buildApiProxyService with getConfigEnvValue(config, 'COPILOT_MODEL').

• Behavioral intent

  • No functional behavior change: lookup order and normalization remain identical, now centralized in one helper.

// before
const copilotModel = getCopilotModel(config);

// after
const copilotModel = getConfigEnvValue(config, 'COPILOT_MODEL');

[Copilot]

Pull request overview

Refactors src/services/api-proxy-service.ts to centralize COPILOT_MODEL environment resolution logic, reducing duplication and drift risk while preserving the existing precedence order and normalization.

Changes:

• Removed the dedicated getCopilotModel(config) helper.
• Reused the existing getConfigEnvValue(config, key) helper for COPILOT_MODEL resolution at the single call site.

Show a summary per file

File	Description
src/services/api-proxy-service.ts	Removes duplicated COPILOT_MODEL resolution helper and updates the call site to use the shared config/env lookup utility.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0

[github-actions]

🔬 Smoke Test Results

Test	Status
GitHub MCP connectivity	✅
GitHub.com HTTP	✅ 200
File write/read	✅

Overall: PASS — @Copilot

Run: 26037938747

📰 BREAKING: Report filed by Smoke Copilot

[github-actions]

🔍 Smoke Test Results

Test	Status	Details
GitHub API (gh CLI)	❌ FAIL	HTTP 401 authentication error
Playwright (browser)	✅ PASS	Title contains "GitHub"
File verify	✅ PASS	smoke-test-claude-26037938907.txt exists

Result: 2/3 PASS — GitHub API authentication failed (pre-auth may not be configured for this context)

💥 [THE END] — Illustrated by Smoke Claude

[github-actions]

🧪 Smoke Test: Copilot BYOK Offline Mode

Test	Result
GitHub MCP connectivity	❌ 401 (MCP auth unavailable in sandbox)
GitHub.com HTTP	✅ (pre-step passed)
File write/read (smoke-test-copilot-byok-26037938735.txt)	✅ Verified
BYOK inference (agent → api-proxy → api.githubcopilot.com)	✅ Responding now

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com.

Overall: PASS (GitHub MCP 401 is a sandbox constraint, not a BYOK failure)

🔑 BYOK report filed by Smoke Copilot BYOK

[github-actions]

✅ GitHub PR review: fix: resolve test failures on macOS; fix: postprocess claude-token-optimizer lock file to use local awf build
❌ Safeinputs GH CLI: safeinputs-gh unavailable
✅ Playwright: GitHub title verified
❌ Tavily search: no Tavily tools exposed
✅ File+Bash: smoke file read back
✅ Build: npm ci && npm run build
⏭ Discussion: github-discussion-query unavailable
Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

[github-actions]

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.13	Python 3.12.3	❌
Node.js	v24.15.0	v20.20.2	❌
Go	go1.22.12	go1.22.12	✅

Overall: FAILED — Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot

[github-actions]

Smoke Test Results

• Redis PING: ❌ (timeout/no response)
• PostgreSQL pg_isready: ❌ (no response on port 5432)
• PostgreSQL SELECT 1: ❌ (skipped, host unreachable)

Overall: FAIL — host.docker.internal is not reachable from this environment. Service containers may not be running or the host alias is not resolvable.

🔌 Service connectivity validated by Smoke Services

[github-actions]

Gemini Engine Smoke Test: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

[github-actions]

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	All passed	✅ PASS
Node.js	execa	✅	All passed	✅ PASS
Node.js	p-limit	✅	All passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #3325 · ● 6.6M · ◷