fix: add resilient gh-aw installer and --ignore-scripts to lock files#3363
Conversation
- Add shared/mcp/gh-aw.md import to ci-cd-gaps-assessment and pelis-agent-factory-advisor workflows so they use the resilient install-gh-aw.sh installer instead of legacy gh extension install - Add --ignore-scripts injection for Claude Code npm installs in postprocess-smoke-workflows.ts (supply-chain security hardening) - Recompile affected lock files All 1952 tests now pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
This PR hardens generated workflow installs by using the resilient gh-aw installer path and ensuring Claude Code CLI installs disable npm lifecycle scripts.
Changes:
- Adds
shared/mcp/gh-aw.mdimports to workflows that were still emitting legacy gh-aw extension install logic. - Adds post-processing to inject
--ignore-scriptsinto Claude Code npm installs. - Recompiles affected lock workflows.
Show a summary per file
| File | Description |
|---|---|
scripts/ci/postprocess-smoke-workflows.ts |
Adds Claude Code npm install post-processing. |
.github/workflows/smoke-claude.lock.yml |
Adds --ignore-scripts to Claude Code install. |
.github/workflows/security-guard.lock.yml |
Adds --ignore-scripts to Claude Code install. |
.github/workflows/secret-digger-claude.lock.yml |
Adds --ignore-scripts to both Claude Code installs. |
.github/workflows/pelis-agent-factory-advisor.md |
Imports shared gh-aw installer component. |
.github/workflows/pelis-agent-factory-advisor.lock.yml |
Regenerated with shared gh-aw installer. |
.github/workflows/ci-cd-gaps-assessment.md |
Imports shared gh-aw installer component. |
.github/workflows/ci-cd-gaps-assessment.lock.yml |
Regenerated with shared gh-aw installer. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 8/8 changed files
- Comments generated: 1
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
🔬 Smoke Test Results
PR: fix: add resilient gh-aw installer and --ignore-scripts to lock files Overall: PARTIAL — MCP test passed; pre-step outputs were not interpolated before agent execution.
|
🔥 Smoke Test: Copilot BYOK (Offline) Mode
Running in BYOK offline mode ( PR by @lpcox — "fix: add resilient gh-aw installer and --ignore-scripts to lock files" Overall: PARTIAL (MCP + BYOK inference ✅; pre-step outputs not interpolated
|
|
GitHub PR review ✅ chore: recompile all workflow lock files; refactor: split token-tracker.js into four focused modules Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
Smoke Test Results
Overall Status: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
Smoke Test: Services Connectivity
Overall: FAIL —
|
Fixes 2 failing npm tests (workflow-gh-aw-install and workflow-engine-install-security).
Root Cause
Legacy gh-aw installer:
ci-cd-gaps-assessmentandpelis-agent-factory-advisorworkflows didn't importshared/mcp/gh-aw.md, so the compiler emitted the legacygh extension install/upgradepattern instead of the resilientinstall-gh-aw.shinstaller.Missing
--ignore-scripts: The gh-aw compiler emits Claude Code installs without--ignore-scripts, unlike Codex installs which include it.Fix
shared/mcp/gh-aw.mdimport to both affected workflow.mdfiles--ignore-scriptsinjection for Claude Code installs inpostprocess-smoke-workflows.tsAll 1952 tests pass.