Skip to content

fix: add resilient gh-aw installer and --ignore-scripts to lock files#3363

Merged
lpcox merged 2 commits into
mainfrom
fix/lock-file-test-failures
May 18, 2026
Merged

fix: add resilient gh-aw installer and --ignore-scripts to lock files#3363
lpcox merged 2 commits into
mainfrom
fix/lock-file-test-failures

Conversation

@lpcox
Copy link
Copy Markdown
Collaborator

@lpcox lpcox commented May 18, 2026

Fixes 2 failing npm tests (workflow-gh-aw-install and workflow-engine-install-security).

Root Cause

  1. Legacy gh-aw installer: ci-cd-gaps-assessment and pelis-agent-factory-advisor workflows didn't import shared/mcp/gh-aw.md, so the compiler emitted the legacy gh extension install/upgrade pattern instead of the resilient install-gh-aw.sh installer.

  2. Missing --ignore-scripts: The gh-aw compiler emits Claude Code installs without --ignore-scripts, unlike Codex installs which include it.

Fix

  • Added shared/mcp/gh-aw.md import to both affected workflow .md files
  • Added --ignore-scripts injection for Claude Code installs in postprocess-smoke-workflows.ts
  • Recompiled affected lock files

All 1952 tests pass.

- Add shared/mcp/gh-aw.md import to ci-cd-gaps-assessment and
  pelis-agent-factory-advisor workflows so they use the resilient
  install-gh-aw.sh installer instead of legacy gh extension install
- Add --ignore-scripts injection for Claude Code npm installs in
  postprocess-smoke-workflows.ts (supply-chain security hardening)
- Recompile affected lock files

All 1952 tests now pass.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 18, 2026 22:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 95.39% 95.47% 📈 +0.08%
Statements 95.21% 95.28% 📈 +0.07%
Functions 96.74% 96.74% ➡️ +0.00%
Branches 88.04% 88.08% 📈 +0.04%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/config-writer.ts 83.0% → 85.6% (+2.54%) 83.0% → 85.6% (+2.54%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens generated workflow installs by using the resilient gh-aw installer path and ensuring Claude Code CLI installs disable npm lifecycle scripts.

Changes:

  • Adds shared/mcp/gh-aw.md imports to workflows that were still emitting legacy gh-aw extension install logic.
  • Adds post-processing to inject --ignore-scripts into Claude Code npm installs.
  • Recompiles affected lock workflows.
Show a summary per file
File Description
scripts/ci/postprocess-smoke-workflows.ts Adds Claude Code npm install post-processing.
.github/workflows/smoke-claude.lock.yml Adds --ignore-scripts to Claude Code install.
.github/workflows/security-guard.lock.yml Adds --ignore-scripts to Claude Code install.
.github/workflows/secret-digger-claude.lock.yml Adds --ignore-scripts to both Claude Code installs.
.github/workflows/pelis-agent-factory-advisor.md Imports shared gh-aw installer component.
.github/workflows/pelis-agent-factory-advisor.lock.yml Regenerated with shared gh-aw installer.
.github/workflows/ci-cd-gaps-assessment.md Imports shared gh-aw installer component.
.github/workflows/ci-cd-gaps-assessment.lock.yml Regenerated with shared gh-aw installer.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 8/8 changed files
  • Comments generated: 1

Comment thread scripts/ci/postprocess-smoke-workflows.ts Outdated
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

🔬 Smoke Test Results

Test Result
GitHub MCP connectivity ✅ Pass
GitHub.com HTTP connectivity ⚠️ N/A (template vars unexpanded)
File write/read ⚠️ N/A (template vars unexpanded)

PR: fix: add resilient gh-aw installer and --ignore-scripts to lock files
Author: @lpcox | Assignees: none

Overall: PARTIAL — MCP test passed; pre-step outputs were not interpolated before agent execution.

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

🔥 Smoke Test: Copilot BYOK (Offline) Mode

Test Result
GitHub MCP connectivity ✅ PR #3363 fetched successfully
GitHub.com connectivity ⚠️ Pre-step template vars not expanded (${{ steps.smoke-data.outputs... }})
File write/read ⚠️ Pre-step template vars not expanded
BYOK inference (agent → api-proxy → api.githubcopilot.com) ✅ Responding now

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com.

PR by @lpcox"fix: add resilient gh-aw installer and --ignore-scripts to lock files"

Overall: PARTIAL (MCP + BYOK inference ✅; pre-step outputs not interpolated ⚠️)

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions
Copy link
Copy Markdown
Contributor

GitHub PR review ✅ chore: recompile all workflow lock files; refactor: split token-tracker.js into four focused modules
Safe Inputs GH CLI ❌ safeinputs-gh missing; gh fallback returned: fix: add resilient gh-aw installer and --ignore-scripts to lock files; Refactor container cleanup to deduplicate log/session preservation paths
Playwright ✅ GitHub title verified
Tavily ❌ server exposes no search tool
File+Bash ✅ /tmp/gh-aw/agent/smoke-test-codex-26065142812.txt verified
Discussion ✅ #3362 oracle comment posted
Build ✅ npm ci && npm run build
Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions
Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx passed ✅ PASS
Node.js execa passed ✅ PASS
Node.js p-limit passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #3363 · ● 4.5M ·

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

  • GitHub MCP Testing: ❌
  • GitHub.com Connectivity: ❌
  • File Writing Testing: ✅
  • Bash Tool Testing: ✅

Overall Status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test: Services Connectivity

Check Result
Redis PING ❌ timeout/no response
PostgreSQL pg_isready ❌ no response
PostgreSQL SELECT 1 ❌ timeout/no response

Overall: FAILhost.docker.internal is unreachable on ports 6379 and 5432. Service containers may not be running or host network bridging is unavailable in this environment.

🔌 Service connectivity validated by Smoke Services

@lpcox lpcox enabled auto-merge (squash) May 18, 2026 23:05
@lpcox lpcox merged commit 17037e9 into main May 18, 2026
62 of 65 checks passed
@lpcox lpcox deleted the fix/lock-file-test-failures branch May 18, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants