fix: revert --ignore-scripts for Claude Code (needs postinstall)#3371
Conversation
- Add shared/mcp/gh-aw.md import to ci-cd-gaps-assessment and pelis-agent-factory-advisor workflows so they use the resilient install-gh-aw.sh installer instead of legacy gh extension install - Add --ignore-scripts injection for Claude Code npm installs in postprocess-smoke-workflows.ts (supply-chain security hardening) - Recompile affected lock files All 1952 tests now pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Claude Code's postinstall script downloads the platform-specific native binary. With --ignore-scripts, `claude` fails at runtime with "native binary not installed". Changes: - Remove --ignore-scripts injection for Claude Code from postprocess script - Update test to only require --ignore-scripts for Codex (not Claude Code) - Revert --ignore-scripts in affected lock files Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR reverts the Claude Code --ignore-scripts install behavior because Claude Code requires its postinstall script to download the native binary, while preserving stricter install checks for Codex and updating affected generated workflows.
Changes:
- Excludes Claude Code from the install-security test rule requiring
--ignore-scripts. - Documents in the smoke workflow postprocessor why Claude Code must not use
--ignore-scripts. - Adds the shared
gh-awMCP import and regenerated lock workflow content for two workflows.
Show a summary per file
| File | Description |
|---|---|
scripts/ci/workflow-engine-install-security.test.ts |
Narrows install-security enforcement to Codex only. |
scripts/ci/postprocess-smoke-workflows.ts |
Adds comments documenting Claude Code postinstall requirements. |
.github/workflows/pelis-agent-factory-advisor.md |
Imports shared gh-aw MCP setup. |
.github/workflows/pelis-agent-factory-advisor.lock.yml |
Regenerated lock file with shared gh-aw setup. |
.github/workflows/ci-cd-gaps-assessment.md |
Imports shared gh-aw MCP setup. |
.github/workflows/ci-cd-gaps-assessment.lock.yml |
Regenerated lock file with shared gh-aw setup. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 6/6 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
🔬 Smoke Test Results
Overall: PASS ✅ PR: fix: revert --ignore-scripts for Claude Code (needs postinstall)
|
🔥 Smoke Test: Copilot BYOK (Offline) Mode
Running in BYOK offline mode ( Author: @lpcox | Overall: PASS (core BYOK path verified)
|
Smoke Test SummaryPRs: fix: add resilient gh-aw installer and --ignore-scripts to lock files; Refactor container cleanup to deduplicate log/session preservation paths Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Gemini Engine Smoke Test Results
Overall status: FAIL (MCP CLI tools missing from environment) Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
Smoke Test Results — FAIL
|
Recompiles all lock files to pick up the Claude Code --ignore-scripts revert from #3371. Claude Code installs now run without --ignore-scripts so the postinstall can download the native binary. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Problem
PR #3363 added
--ignore-scriptsto Claude Code's npm install in the post-processing script. However, Claude Code's postinstall downloads the platform-specific native binary — without it,claudefails at runtime with:This was caught by the Smoke Claude workflow failing: https://github.com/github/gh-aw-firewall/actions/runs/26064933319
Fix
--ignore-scriptsinjection for Claude Code frompostprocess-smoke-workflows.tsworkflow-engine-install-security.test.tsto only require--ignore-scriptsfor Codex (which is pure JS and doesn't need postinstall)--ignore-scriptsin affected lock files (smoke-claude,secret-digger-claude,security-guard)Context
@openai/codex): Pure JS, works fine with--ignore-scripts✅@anthropic-ai/claude-code): Needs postinstall for native binary ❌Supersedes the --ignore-scripts portion of #3363.