Skip to content

chore: recompile workflows after --ignore-scripts revert#3378

Merged
lpcox merged 1 commit into
mainfrom
chore/recompile-workflows-may19
May 19, 2026
Merged

chore: recompile workflows after --ignore-scripts revert#3378
lpcox merged 1 commit into
mainfrom
chore/recompile-workflows-may19

Conversation

@lpcox
Copy link
Copy Markdown
Collaborator

@lpcox lpcox commented May 19, 2026

Recompiles all lock files to pick up the Claude Code --ignore-scripts revert from #3371.

Changes:

  • Claude Code installs in 3 lock files no longer have --ignore-scripts (fixes the smoke-claude native binary error)
  • Minor heredoc hash updates in secret-digger-codex.lock.yml from recompilation

Fixes the test failure in https://github.com/github/gh-aw-firewall/actions/runs/26068025911

Recompiles all lock files to pick up the Claude Code --ignore-scripts
revert from #3371. Claude Code installs now run without --ignore-scripts
so the postinstall can download the native binary.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 19, 2026 00:20
@lpcox lpcox merged commit cd9c5a2 into main May 19, 2026
46 of 48 checks passed
@lpcox lpcox deleted the chore/recompile-workflows-may19 branch May 19, 2026 00:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Recompiles workflow lock files to reflect the revert of --ignore-scripts for Claude Code installs (from #3371), since Claude Code's postinstall is required to fetch the platform-specific native binary. Codex installs remain unaffected.

Changes:

  • Removes --ignore-scripts from Claude Code CLI installs in smoke-claude, security-guard, and secret-digger-claude lock files.
  • Updates regenerated heredoc delimiter hashes in secret-digger-codex.lock.yml.
Show a summary per file
File Description
.github/workflows/smoke-claude.lock.yml Drops --ignore-scripts from Claude Code install step.
.github/workflows/security-guard.lock.yml Drops --ignore-scripts from Claude Code install step.
.github/workflows/secret-digger-claude.lock.yml Drops --ignore-scripts from both Claude Code install steps.
.github/workflows/secret-digger-codex.lock.yml Heredoc delimiter hash refresh from recompile.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 4/4 changed files
  • Comments generated: 0

@github-actions
Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 95.55% 95.62% 📈 +0.07%
Statements 95.36% 95.43% 📈 +0.07%
Functions 96.76% 96.76% ➡️ +0.00%
Branches 88.16% 88.20% 📈 +0.04%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/config-writer.ts 83.0% → 85.6% (+2.54%) 83.0% → 85.6% (+2.54%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Copilot Smoke Test — PASS

Test Result
GitHub MCP (PR list) ✅ PR #3378: "chore: recompile workflows after --ignore-scripts revert"
File write/read smoke-test-copilot-26068294361.txt confirmed
GitHub.com connectivity ✅ (pre-step verified)

Overall: PASS@lpcox

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

Claude Engine Smoke Test Results

GitHub API: 2 PR entries confirmed in recent-prs.json
Playwright: GitHub homepage navigation successful (title contains "GitHub")
File Verify: smoke-test-claude-26068294367.txt exists and readable

PASS — All smoke tests completed successfully.

💥 [THE END] — Illustrated by Smoke Claude

@github-actions
Copy link
Copy Markdown
Contributor

Gemini Engine Smoke Test Results\n\n- GitHub MCP Testing: ❌ (Fetch failed)\n- GitHub.com Connectivity: ❌ (Returned 000)\n- File Writing Testing: ✅\n- Bash Tool Testing: ✅\n\nOverall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Codex: FAIL
chore: recompile workflows after --ignore-scripts revert
Narrow rules API surface by making mergeRuleSets internal
✅ PR read, Playwright, file/bash, build
❌ safeinputs-gh, Tavily search, discussion query
Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions
Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx all passed ✅ PASS
Node.js execa all passed ✅ PASS
Node.js p-limit all passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Note (Java): The default ~/.m2/repository directory was owned by root (no write access). Maven was run with -Dmaven.repo.local=/tmp/gh-aw/agent/m2repo as a workaround — all Java tests passed successfully.

Generated by Build Test Suite for issue #3378 · ● 5.4M ·

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

Check Result
Redis PING ❌ Timeout/no response
PostgreSQL pg_isready ❌ No response
PostgreSQL SELECT 1 ❌ Timeout/error

Overall: FAILhost.docker.internal services are not reachable from this environment. The runner does not appear to have service containers accessible on the expected ports.

🔌 Service connectivity validated by Smoke Services

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test: Copilot BYOK (Offline) Mode

Test Result
GitHub MCP (list PRs) ✅ PR #3378 retrieved
GitHub.com connectivity (HTTP) ✅ HTTP 200
File write/read ⚠️ Unverifiable (template vars not resolved)
BYOK inference (agent → api-proxy → api.githubcopilot.com) ✅ Responding

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com.

PR author: @lpcox · No assignees.

Overall: PASS (file test skipped due to unresolved step outputs)

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions github-actions Bot mentioned this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants