Skip to content

Remove dead host-path-prefix re-exports from agent-volumes#3425

Merged
lpcox merged 1 commit into
mainfrom
copilot/remove-dead-re-exports
May 19, 2026
Merged

Remove dead host-path-prefix re-exports from agent-volumes#3425
lpcox merged 1 commit into
mainfrom
copilot/remove-dead-re-exports

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 19, 2026

src/services/agent-volumes.ts still re-exported three host-path-prefix helpers for “backwards compatibility,” but there are no remaining call sites importing those symbols from agent-volumes. This leaves stale API surface that can mislead future imports.

  • API surface cleanup

    • Removed the backwards-compatibility re-export block for:
      • normalizeDockerHostPathPrefix
      • translateBindMountHostPath
      • applyHostPathPrefixToVolumes
  • Module boundary clarity

    • Kept host-path-prefix.ts as the single canonical module exporting these helpers.
    • No behavioral logic changed in volume construction; this is a surface-area cleanup only.
// removed from src/services/agent-volumes.ts
export {
  normalizeDockerHostPathPrefix,
  translateBindMountHostPath,
  applyHostPathPrefixToVolumes,
};

Copilot AI changed the title [WIP] Remove unused re-exports for backwards compatibility Remove dead host-path-prefix re-exports from agent-volumes May 19, 2026
Copilot finished work on behalf of lpcox May 19, 2026 15:36
Copilot AI requested a review from lpcox May 19, 2026 15:36
@lpcox lpcox marked this pull request as ready for review May 19, 2026 21:34
Copilot AI review requested due to automatic review settings May 19, 2026 21:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@github-actions
Copy link
Copy Markdown
Contributor

🔥 Smoke Test: Copilot BYOK (Offline) Mode

Test Result
GitHub MCP (list PRs) ✅ — PR #3414 "fix: switch doc-maintainer from copilot to claude engine"
GitHub.com connectivity ⚠️ Pre-step data not available (template vars unexpanded)
File write/read ⚠️ Pre-step data not available (template vars unexpanded)
BYOK inference (agent → api-proxy → api.githubcopilot.com)

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com.

PR author: @Copilot · Assignees: @lpcox, @Copilot

Overall: PARTIAL (BYOK inference ✅; pre-step data unavailable for HTTP/file tests)

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

  • ✅ GitHub API: 2 PR entries confirmed
  • ✅ Playwright: GitHub homepage title verified
  • ✅ File verify: Smoke test file exists

Result: PASS

💥 [THE END] — Illustrated by Smoke Claude

@github-actions
Copy link
Copy Markdown
Contributor

🔬 Smoke Test Results

Test Result
GitHub MCP connectivity ✅ PASS
GitHub.com HTTP connectivity ⚠️ N/A (pre-step template vars unexpanded)
File write/read ⚠️ N/A (pre-step template vars unexpanded)

PR: Remove dead host-path-prefix re-exports from agent-volumes
Author: @Copilot | Assignees: @lpcox, @Copilot

Overall: PARTIAL — MCP is functional; pre-computed test data was not injected (workflow template expressions were not evaluated before agent execution).

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

Smoke test failed

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test

✅ Merged PR review: fix: switch doc-maintainer from copilot to claude engine; Optimize Security Guard workflow token usage and reduce runaway turn cost
❌ Safe Inputs GH CLI: safeinputs-gh unavailable; fallback titles: Refactor option parser facade to direct re-exports and unify flag validation type; tests: replace host-env barrel imports with canonical host-env split modules
✅ Playwright: GitHub title verified
❌ Tavily: no search tool exposed by MCP bridge
✅ File/bash: smoke-test-codex-26107297959.txt verified
✅ Discussion: oracle comment posted to 3429
✅ Build: npm ci && npm run build
Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions
Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx all passed ✅ PASS
Node.js execa all passed ✅ PASS
Node.js p-limit all passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #3425 · ● 3.8M ·

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results — FAIL

Check Result
Redis PING ❌ Timeout (no response)
PostgreSQL pg_isready ❌ No response
PostgreSQL SELECT 1 ❌ Timeout (no response)

Overall: FAILhost.docker.internal is not reachable from this runner environment. Service containers may not be running or the host alias is not resolvable.

🔌 Service connectivity validated by Smoke Services

@lpcox lpcox merged commit 89ca802 into main May 19, 2026
37 of 41 checks passed
@lpcox lpcox deleted the copilot/remove-dead-re-exports branch May 19, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Export Audit] Dead backwards-compatibility re-exports in src/services/agent-volumes.ts

3 participants