Prune dead host-env compatibility re-exports after module split#3426
Conversation
host-env compatibility re-exports after module split
|
| Metric | Base | PR | Delta |
|---|---|---|---|
| Lines | 95.57% | 95.62% | 📈 +0.05% |
| Statements | 95.40% | 95.45% | 📈 +0.05% |
| Functions | 96.55% | 96.41% | 📉 -0.14% |
| Branches | 87.91% | 87.95% | 📈 +0.04% |
📁 Per-file Coverage Changes (2 files)
| File | Lines (Before → After) | Statements (Before → After) |
|---|---|---|
src/host-env.ts |
97.0% → 95.9% (-1.14%) | 95.7% → 94.1% (-1.60%) |
src/config-writer.ts |
83.0% → 85.6% (+2.54%) | 83.0% → 85.6% (+2.54%) |
Coverage comparison generated by scripts/ci/compare-coverage.ts
There was a problem hiding this comment.
Pull request overview
Cleans up the src/host-env.ts backward-compat barrel after the host-env module split by removing re-exports that are no longer consumed via that path, and updates tests to import those symbols from their canonical modules.
Changes:
- Removed dead compatibility re-exports from
src/host-env.ts(constants, host-identity, github-env symbols). - Updated tests to import the affected symbols from
./constants,./host-identity, and./github-envinstead of./host-env. - Kept
src/host-env.tsfocused on the small set of production-consumed exports.
Show a summary per file
| File | Description |
|---|---|
| src/host-env.ts | Removes unused barrel re-exports and narrows exported surface to production-consumed symbols. |
| src/docker-manager-utils.test.ts | Re-aligns imports to canonical modules (host-identity + github-env) while keeping host-env-only helpers. |
| src/docker-manager-lifecycle.test.ts | Switches AGENT_CONTAINER_NAME import to ./constants. |
| src/compose-generator.test.ts | Switches ACT_PRESET_BASE_IMAGE import to ./host-identity. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 1
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
| Metric | Base | PR | Delta |
|---|---|---|---|
| Lines | 95.57% | 95.60% | 📈 +0.03% |
| Statements | 95.40% | 95.44% | 📈 +0.04% |
| Functions | 96.55% | 96.41% | 📉 -0.14% |
| Branches | 87.91% | 87.95% | 📈 +0.04% |
📁 Per-file Coverage Changes (3 files)
| File | Lines (Before → After) | Statements (Before → After) |
|---|---|---|
src/host-env.ts |
97.0% → 95.9% (-1.14%) | 95.7% → 94.1% (-1.60%) |
src/option-parsers.ts |
99.0% → 98.8% (-0.20%) | 99.0% → 98.9% (-0.15%) |
src/config-writer.ts |
83.0% → 85.6% (+2.54%) | 83.0% → 85.6% (+2.54%) |
Coverage comparison generated by scripts/ci/compare-coverage.ts
Smoke Test Results✅ GitHub API: Confirmed 2 PR entries in recent-prs.json Result: PASS
|
|
Smoke Test: Copilot BYOK (Offline Mode)
Running in BYOK offline mode ( PR author: Overall: PASS
|
🔬 Smoke Test Results
PR: Prune dead Overall: PARTIAL — MCP ✅, pre-step smoke data outputs were not substituted (template variables unexpanded).
|
|
PRs: Refactor option parser facade to direct re-exports and unify flag validation type; fix: switch doc-maintainer from copilot to claude engine; tests: replace host-env barrel imports with canonical host-env split modules; Prune dead Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Chroot Smoke Test Results
Overall: ❌ FAILED — Python and Node.js versions differ between host and chroot environment.
|
Smoke Test Results: Gemini
Last 2 merged PRs:
Overall status: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
Smoke Test Results
Overall: FAIL —
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
After the host-env module split,
src/host-env.tsstill re-exported 18 symbols that no production code consumes through that barrel path. This PR removes those dead compatibility exports and aligns remaining test callers with canonical module import paths.API surface cleanup (
src/host-env.ts)./constants(container names + env size constants)./host-identity(ACT_PRESET_BASE_IMAGE,MIN_REGULAR_UID,validateIdNotInSystemRange)./github-env(GitHub env/path parsing helpers + toolchain vars)SQUID_PORT, host UID/GID/home helpers, etc.).Test import realignment (canonical ownership)
./host-envto import from their source modules:src/docker-manager-utils.test.tssrc/docker-manager-lifecycle.test.tssrc/compose-generator.test.tsRepresentative change