Skip to content

fix: run_containerized.sh now accepts MCP_GATEWAY_AGENT_ID as primary deployment gate variable#7212

Merged
lpcox merged 3 commits into
mainfrom
copilot/fix-docs-reconciliation-issue
Jun 8, 2026
Merged

fix: run_containerized.sh now accepts MCP_GATEWAY_AGENT_ID as primary deployment gate variable#7212
lpcox merged 3 commits into
mainfrom
copilot/fix-docs-reconciliation-issue

Conversation

Copilot AI commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

run_containerized.sh only checked MCP_GATEWAY_API_KEY while the README Quick Start (and validation_env.go) already used MCP_GATEWAY_AGENT_ID, causing immediate container startup failure for anyone following the docs.

Changes

  • run_containerized.shcheck_required_env_vars() now mirrors validation_env.go: accepts MCP_GATEWAY_AGENT_ID (preferred) or falls back to MCP_GATEWAY_API_KEY with a deprecation warning. Error hint updated accordingly.

    # Before: required MCP_GATEWAY_API_KEY
    # After: accepts either, warns on deprecated name
    [WARN] MCP_GATEWAY_API_KEY is deprecated; please rename it to MCP_GATEWAY_AGENT_ID
  • CONTRIBUTING.md — Docker development examples updated from MCP_GATEWAY_API_KEY / "apiKey" to MCP_GATEWAY_AGENT_ID / "agentId", consistent with README guidance.

  • docs/ENVIRONMENT_VARIABLES.md — No change; line 13 already described the correct intended behaviour. The script now matches it.

Copilot AI linked an issue Jun 8, 2026 that may be closed by this pull request
…mary env var

- Update check_required_env_vars() in run_containerized.sh to accept
  MCP_GATEWAY_AGENT_ID (preferred) or MCP_GATEWAY_API_KEY (deprecated
  fallback with a warning), mirroring the existing behaviour in
  internal/config/validation_env.go
- Update error hint message to show MCP_GATEWAY_AGENT_ID
- Update CONTRIBUTING.md Docker examples to use MCP_GATEWAY_AGENT_ID /
  agentId instead of the deprecated MCP_GATEWAY_API_KEY / apiKey

Fixes: README Quick Start was already using MCP_GATEWAY_AGENT_ID; the
container startup failure was caused by run_containerized.sh only
checking MCP_GATEWAY_API_KEY.

Resolves docs/ENVIRONMENT_VARIABLES.md line 13 (which already described
the correct intended behaviour — now the script matches it).
Copilot AI changed the title [WIP] Fix missing MCP_GATEWAY_API_KEY in Quick Start command fix: run_containerized.sh now accepts MCP_GATEWAY_AGENT_ID as primary deployment gate variable Jun 8, 2026
Copilot finished work on behalf of lpcox June 8, 2026 14:15
Copilot AI requested a review from lpcox June 8, 2026 14:15
@lpcox lpcox marked this pull request as ready for review June 8, 2026 14:36
Copilot AI review requested due to automatic review settings June 8, 2026 14:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns container entrypoint env-var validation with the documented/implemented MCP_GATEWAY_AGENT_ID deployment gate, fixing container startup failures when following the Quick Start.

Changes:

  • Update run_containerized.sh to accept MCP_GATEWAY_AGENT_ID (preferred) or MCP_GATEWAY_API_KEY (deprecated) and emit a deprecation warning when using the legacy name.
  • Update Docker development examples in CONTRIBUTING.md to use MCP_GATEWAY_AGENT_ID / gateway.agentId.
Show a summary per file
File Description
run_containerized.sh Updates required env-var checks to prefer MCP_GATEWAY_AGENT_ID and warn on legacy MCP_GATEWAY_API_KEY.
CONTRIBUTING.md Updates Docker run/config examples to use MCP_GATEWAY_AGENT_ID and gateway.agentId.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 1

Comment thread run_containerized.sh
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@lpcox lpcox merged commit 9b7e950 into main Jun 8, 2026
3 checks passed
@lpcox lpcox deleted the copilot/fix-docs-reconciliation-issue branch June 8, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📚 Documentation Reconciliation Report - 2026-06-07

3 participants