Fix TestStopTimeResolutionIntegration to check for correct environment variable format#2153
Merged
Conversation
…rmat Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues in test suite
Fix TestStopTimeResolutionIntegration to check for correct environment variable format
Oct 22, 2025
Contributor
|
Agentic Changeset Generator triggered by this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
TestStopTimeResolutionIntegrationtest suite was failing because it was checking for the wrong format in compiled workflow files. The test expected to findSTOP_TIME=(shell script format), but the actual implementation usesGH_AW_STOP_TIME:as a YAML environment variable in theactions/github-script@v8step.Root Cause
The test was written to look for shell script-style environment variable assignment:
STOP_TIME="2025-12-31 23:59:59"However, the compiler actually generates YAML format:
This mismatch was causing all sub-tests in
TestStopTimeResolutionIntegrationto fail with errors like:Changes
Updated
pkg/workflow/time_delta_integration_test.goto:STOP_TIME=toGH_AW_STOP_TIME:strings.SplitN()with colon delimiter instead of looking for quoted valuesGH_AW_STOP_TIMEfor consistencyTesting
All 7 sub-tests in
TestStopTimeResolutionIntegrationnow pass:Full test suite passes without any failures.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.