diff --git a/.github/workflows/copilot-pr-merged-report.lock.yml b/.github/workflows/copilot-pr-merged-report.lock.yml index 035b665f687..056bbc70158 100644 --- a/.github/workflows/copilot-pr-merged-report.lock.yml +++ b/.github/workflows/copilot-pr-merged-report.lock.yml @@ -573,7 +573,7 @@ jobs: bash ${RUNNER_TEMP}/gh-aw/actions/start_safe_outputs_server.sh - - name: Setup MCP Scripts Config + - name: Write MCP Scripts Config run: | mkdir -p ${RUNNER_TEMP}/gh-aw/mcp-scripts/logs cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/tools.json << 'GH_AW_MCP_SCRIPTS_TOOLS_668c234bd11c168e_EOF' @@ -624,7 +624,7 @@ jobs: GH_AW_MCP_SCRIPTS_SERVER_0244857e55b4d1a9_EOF chmod +x ${RUNNER_TEMP}/gh-aw/mcp-scripts/mcp-server.cjs - - name: Setup MCP Scripts Tool Files + - name: Write MCP Scripts Tool Files run: | cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/gh.sh << 'GH_AW_MCP_SCRIPTS_SH_GH_f381fd4bda351416_EOF' #!/bin/bash diff --git a/.github/workflows/daily-choice-test.lock.yml b/.github/workflows/daily-choice-test.lock.yml index 9e959f4fc2d..6519900dae1 100644 --- a/.github/workflows/daily-choice-test.lock.yml +++ b/.github/workflows/daily-choice-test.lock.yml @@ -1281,7 +1281,7 @@ jobs: with: name: agent path: ${{ runner.temp }}/gh-aw/safe-jobs/ - - name: Setup Safe Job Environment Variables + - name: Configure Safe Job Environment Variables id: setup-safe-job-env run: | find "${RUNNER_TEMP}/gh-aw/safe-jobs/" -type f -print diff --git a/.github/workflows/daily-cli-performance.lock.yml b/.github/workflows/daily-cli-performance.lock.yml index a382129a642..3a955230fc1 100644 --- a/.github/workflows/daily-cli-performance.lock.yml +++ b/.github/workflows/daily-cli-performance.lock.yml @@ -627,7 +627,7 @@ jobs: bash ${RUNNER_TEMP}/gh-aw/actions/start_safe_outputs_server.sh - - name: Setup MCP Scripts Config + - name: Write MCP Scripts Config run: | mkdir -p ${RUNNER_TEMP}/gh-aw/mcp-scripts/logs cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/tools.json << 'GH_AW_MCP_SCRIPTS_TOOLS_5d19fc88280e6234_EOF' @@ -692,7 +692,7 @@ jobs: GH_AW_MCP_SCRIPTS_SERVER_124be5f8aac3f3e6_EOF chmod +x ${RUNNER_TEMP}/gh-aw/mcp-scripts/mcp-server.cjs - - name: Setup MCP Scripts Tool Files + - name: Write MCP Scripts Tool Files run: | cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/go.sh << 'GH_AW_MCP_SCRIPTS_SH_GO_b8bc2d81aca76663_EOF' #!/bin/bash diff --git a/.github/workflows/daily-performance-summary.lock.yml b/.github/workflows/daily-performance-summary.lock.yml index 7efbff84abd..8ee88601f05 100644 --- a/.github/workflows/daily-performance-summary.lock.yml +++ b/.github/workflows/daily-performance-summary.lock.yml @@ -616,7 +616,7 @@ jobs: bash ${RUNNER_TEMP}/gh-aw/actions/start_safe_outputs_server.sh - - name: Setup MCP Scripts Config + - name: Write MCP Scripts Config run: | mkdir -p ${RUNNER_TEMP}/gh-aw/mcp-scripts/logs cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/tools.json << 'GH_AW_MCP_SCRIPTS_TOOLS_27c89a4e7bb71937_EOF' @@ -731,7 +731,7 @@ jobs: GH_AW_MCP_SCRIPTS_SERVER_b6c1a29ccb77cf9d_EOF chmod +x ${RUNNER_TEMP}/gh-aw/mcp-scripts/mcp-server.cjs - - name: Setup MCP Scripts Tool Files + - name: Write MCP Scripts Tool Files run: | cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/github-discussion-query.sh << 'GH_AW_MCP_SCRIPTS_SH_GITHUB-DISCUSSION-QUERY_e556a7482a45cf49_EOF' #!/bin/bash diff --git a/.github/workflows/daily-regulatory.lock.yml b/.github/workflows/daily-regulatory.lock.yml index d92624ec717..e6f0d891b31 100644 --- a/.github/workflows/daily-regulatory.lock.yml +++ b/.github/workflows/daily-regulatory.lock.yml @@ -552,7 +552,7 @@ jobs: bash ${RUNNER_TEMP}/gh-aw/actions/start_safe_outputs_server.sh - - name: Setup MCP Scripts Config + - name: Write MCP Scripts Config run: | mkdir -p ${RUNNER_TEMP}/gh-aw/mcp-scripts/logs cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/tools.json << 'GH_AW_MCP_SCRIPTS_TOOLS_6a740196e20fcf86_EOF' @@ -667,7 +667,7 @@ jobs: GH_AW_MCP_SCRIPTS_SERVER_e8a923a1f948e2bb_EOF chmod +x ${RUNNER_TEMP}/gh-aw/mcp-scripts/mcp-server.cjs - - name: Setup MCP Scripts Tool Files + - name: Write MCP Scripts Tool Files run: | cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/github-discussion-query.sh << 'GH_AW_MCP_SCRIPTS_SH_GITHUB-DISCUSSION-QUERY_bd3de02d3c712c90_EOF' #!/bin/bash diff --git a/.github/workflows/go-logger.lock.yml b/.github/workflows/go-logger.lock.yml index 3aad66e7ec9..38facea75a7 100644 --- a/.github/workflows/go-logger.lock.yml +++ b/.github/workflows/go-logger.lock.yml @@ -590,7 +590,7 @@ jobs: bash ${RUNNER_TEMP}/gh-aw/actions/start_safe_outputs_server.sh - - name: Setup MCP Scripts Config + - name: Write MCP Scripts Config run: | mkdir -p ${RUNNER_TEMP}/gh-aw/mcp-scripts/logs cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/tools.json << 'GH_AW_MCP_SCRIPTS_TOOLS_d4308145d046b7ea_EOF' @@ -655,7 +655,7 @@ jobs: GH_AW_MCP_SCRIPTS_SERVER_fb68386073d403f4_EOF chmod +x ${RUNNER_TEMP}/gh-aw/mcp-scripts/mcp-server.cjs - - name: Setup MCP Scripts Tool Files + - name: Write MCP Scripts Tool Files run: | cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/go.sh << 'GH_AW_MCP_SCRIPTS_SH_GO_3742041ee09eec52_EOF' #!/bin/bash diff --git a/.github/workflows/mcp-inspector.lock.yml b/.github/workflows/mcp-inspector.lock.yml index 0e17275199a..b49b363769f 100644 --- a/.github/workflows/mcp-inspector.lock.yml +++ b/.github/workflows/mcp-inspector.lock.yml @@ -1661,7 +1661,7 @@ jobs: with: name: agent path: ${{ runner.temp }}/gh-aw/safe-jobs/ - - name: Setup Safe Job Environment Variables + - name: Configure Safe Job Environment Variables id: setup-safe-job-env run: | find "${RUNNER_TEMP}/gh-aw/safe-jobs/" -type f -print @@ -1792,7 +1792,7 @@ jobs: with: name: agent path: ${{ runner.temp }}/gh-aw/safe-jobs/ - - name: Setup Safe Job Environment Variables + - name: Configure Safe Job Environment Variables id: setup-safe-job-env run: | find "${RUNNER_TEMP}/gh-aw/safe-jobs/" -type f -print diff --git a/.github/workflows/notion-issue-summary.lock.yml b/.github/workflows/notion-issue-summary.lock.yml index fdb5d9fd789..31a6cc5774d 100644 --- a/.github/workflows/notion-issue-summary.lock.yml +++ b/.github/workflows/notion-issue-summary.lock.yml @@ -1102,7 +1102,7 @@ jobs: with: name: agent path: ${{ runner.temp }}/gh-aw/safe-jobs/ - - name: Setup Safe Job Environment Variables + - name: Configure Safe Job Environment Variables id: setup-safe-job-env run: | find "${RUNNER_TEMP}/gh-aw/safe-jobs/" -type f -print diff --git a/.github/workflows/smoke-claude.lock.yml b/.github/workflows/smoke-claude.lock.yml index ee08ce20a83..a1413603759 100644 --- a/.github/workflows/smoke-claude.lock.yml +++ b/.github/workflows/smoke-claude.lock.yml @@ -1380,7 +1380,7 @@ jobs: bash ${RUNNER_TEMP}/gh-aw/actions/start_safe_outputs_server.sh - - name: Setup MCP Scripts Config + - name: Write MCP Scripts Config run: | mkdir -p ${RUNNER_TEMP}/gh-aw/mcp-scripts/logs cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/tools.json << 'GH_AW_MCP_SCRIPTS_TOOLS_366e65d6f1dfcf37_EOF' @@ -1553,7 +1553,7 @@ jobs: GH_AW_MCP_SCRIPTS_SERVER_65373c4dd9fe570a_EOF chmod +x ${RUNNER_TEMP}/gh-aw/mcp-scripts/mcp-server.cjs - - name: Setup MCP Scripts Tool Files + - name: Write MCP Scripts Tool Files run: | cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/gh.sh << 'GH_AW_MCP_SCRIPTS_SH_GH_d37845b69526d1d0_EOF' #!/bin/bash @@ -2916,7 +2916,7 @@ jobs: GH_HOST="${GITHUB_SERVER_URL#https://}" GH_HOST="${GH_HOST#http://}" echo "GH_HOST=${GH_HOST}" >> "$GITHUB_ENV" - - name: Setup Safe Outputs Custom Scripts + - name: Configure Safe Outputs Custom Scripts run: | cat > ${RUNNER_TEMP}/gh-aw/actions/safe_output_script_post_slack_message.cjs << 'GH_AW_SAFE_OUTPUT_SCRIPT_POST_SLACK_MESSAGE_551ad3d0c1083150_EOF' // @ts-check diff --git a/.github/workflows/smoke-codex.lock.yml b/.github/workflows/smoke-codex.lock.yml index 843308c0c66..558635cfc76 100644 --- a/.github/workflows/smoke-codex.lock.yml +++ b/.github/workflows/smoke-codex.lock.yml @@ -849,7 +849,7 @@ jobs: bash ${RUNNER_TEMP}/gh-aw/actions/start_safe_outputs_server.sh - - name: Setup MCP Scripts Config + - name: Write MCP Scripts Config run: | mkdir -p ${RUNNER_TEMP}/gh-aw/mcp-scripts/logs cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/tools.json << 'GH_AW_MCP_SCRIPTS_TOOLS_2925f8f9ba753614_EOF' @@ -900,7 +900,7 @@ jobs: GH_AW_MCP_SCRIPTS_SERVER_13c4e807f5807b90_EOF chmod +x ${RUNNER_TEMP}/gh-aw/mcp-scripts/mcp-server.cjs - - name: Setup MCP Scripts Tool Files + - name: Write MCP Scripts Tool Files run: | cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/gh.sh << 'GH_AW_MCP_SCRIPTS_SH_GH_6129ac94eceb1ef7_EOF' #!/bin/bash diff --git a/.github/workflows/smoke-copilot-arm.lock.yml b/.github/workflows/smoke-copilot-arm.lock.yml index 93f6599c125..0566cab756c 100644 --- a/.github/workflows/smoke-copilot-arm.lock.yml +++ b/.github/workflows/smoke-copilot-arm.lock.yml @@ -925,7 +925,7 @@ jobs: bash ${RUNNER_TEMP}/gh-aw/actions/start_safe_outputs_server.sh - - name: Setup MCP Scripts Config + - name: Write MCP Scripts Config run: | mkdir -p ${RUNNER_TEMP}/gh-aw/mcp-scripts/logs cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/tools.json << 'GH_AW_MCP_SCRIPTS_TOOLS_79ea45d6c8a5ba06_EOF' @@ -1062,7 +1062,7 @@ jobs: GH_AW_MCP_SCRIPTS_SERVER_8aef5bda2801960f_EOF chmod +x ${RUNNER_TEMP}/gh-aw/mcp-scripts/mcp-server.cjs - - name: Setup MCP Scripts Tool Files + - name: Write MCP Scripts Tool Files run: | cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/gh.sh << 'GH_AW_MCP_SCRIPTS_SH_GH_82681cc1f8f62335_EOF' #!/bin/bash @@ -2265,7 +2265,7 @@ jobs: with: name: agent path: ${{ runner.temp }}/gh-aw/safe-jobs/ - - name: Setup Safe Job Environment Variables + - name: Configure Safe Job Environment Variables id: setup-safe-job-env run: | find "${RUNNER_TEMP}/gh-aw/safe-jobs/" -type f -print diff --git a/.github/workflows/smoke-copilot.lock.yml b/.github/workflows/smoke-copilot.lock.yml index f8bdafa8027..cb239bd47d4 100644 --- a/.github/workflows/smoke-copilot.lock.yml +++ b/.github/workflows/smoke-copilot.lock.yml @@ -974,7 +974,7 @@ jobs: bash ${RUNNER_TEMP}/gh-aw/actions/start_safe_outputs_server.sh - - name: Setup MCP Scripts Config + - name: Write MCP Scripts Config run: | mkdir -p ${RUNNER_TEMP}/gh-aw/mcp-scripts/logs cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/tools.json << 'GH_AW_MCP_SCRIPTS_TOOLS_7babc89e6d790778_EOF' @@ -1111,7 +1111,7 @@ jobs: GH_AW_MCP_SCRIPTS_SERVER_ef1fbc7ce3eca295_EOF chmod +x ${RUNNER_TEMP}/gh-aw/mcp-scripts/mcp-server.cjs - - name: Setup MCP Scripts Tool Files + - name: Write MCP Scripts Tool Files run: | cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/gh.sh << 'GH_AW_MCP_SCRIPTS_SH_GH_5a6688685d632c08_EOF' #!/bin/bash @@ -2315,7 +2315,7 @@ jobs: with: name: agent path: ${{ runner.temp }}/gh-aw/safe-jobs/ - - name: Setup Safe Job Environment Variables + - name: Configure Safe Job Environment Variables id: setup-safe-job-env run: | find "${RUNNER_TEMP}/gh-aw/safe-jobs/" -type f -print diff --git a/.github/workflows/smoke-gemini.lock.yml b/.github/workflows/smoke-gemini.lock.yml index 963a8202736..648befe4ce7 100644 --- a/.github/workflows/smoke-gemini.lock.yml +++ b/.github/workflows/smoke-gemini.lock.yml @@ -678,7 +678,7 @@ jobs: bash ${RUNNER_TEMP}/gh-aw/actions/start_safe_outputs_server.sh - - name: Setup MCP Scripts Config + - name: Write MCP Scripts Config run: | mkdir -p ${RUNNER_TEMP}/gh-aw/mcp-scripts/logs cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/tools.json << 'GH_AW_MCP_SCRIPTS_TOOLS_eeacfabc3ef2402a_EOF' @@ -729,7 +729,7 @@ jobs: GH_AW_MCP_SCRIPTS_SERVER_c7a14968c05f6ed8_EOF chmod +x ${RUNNER_TEMP}/gh-aw/mcp-scripts/mcp-server.cjs - - name: Setup MCP Scripts Tool Files + - name: Write MCP Scripts Tool Files run: | cat > ${RUNNER_TEMP}/gh-aw/mcp-scripts/gh.sh << 'GH_AW_MCP_SCRIPTS_SH_GH_e6f3656b383a4920_EOF' #!/bin/bash diff --git a/pkg/workflow/compiler_safe_outputs_job.go b/pkg/workflow/compiler_safe_outputs_job.go index 64ff65ebfb3..889e2f79135 100644 --- a/pkg/workflow/compiler_safe_outputs_job.go +++ b/pkg/workflow/compiler_safe_outputs_job.go @@ -734,7 +734,7 @@ func buildCustomScriptFilesStep(scripts map[string]*SafeScriptConfig, frontmatte sort.Strings(scriptNames) var steps []string - steps = append(steps, " - name: Setup Safe Outputs Custom Scripts\n") + steps = append(steps, " - name: Configure Safe Outputs Custom Scripts\n") steps = append(steps, " run: |\n") for _, scriptName := range scriptNames { diff --git a/pkg/workflow/mcp_setup_generator.go b/pkg/workflow/mcp_setup_generator.go index 7a65d175faa..392d460d74f 100644 --- a/pkg/workflow/mcp_setup_generator.go +++ b/pkg/workflow/mcp_setup_generator.go @@ -357,7 +357,7 @@ func (c *Compiler) generateMCPSetup(yaml *strings.Builder, tools map[string]any, // For stdio mode, we only write the files but don't start the HTTP server if IsMCPScriptsEnabled(workflowData.MCPScripts, workflowData) { // Step 1: Write config files (JavaScript files are now copied by actions/setup) - yaml.WriteString(" - name: Setup MCP Scripts Config\n") + yaml.WriteString(" - name: Write MCP Scripts Config\n") yaml.WriteString(" run: |\n") yaml.WriteString(" mkdir -p ${RUNNER_TEMP}/gh-aw/mcp-scripts/logs\n") @@ -382,7 +382,7 @@ func (c *Compiler) generateMCPSetup(yaml *strings.Builder, tools map[string]any, yaml.WriteString(" \n") // Step 2: Generate tool files (js/py/sh) - yaml.WriteString(" - name: Setup MCP Scripts Tool Files\n") + yaml.WriteString(" - name: Write MCP Scripts Tool Files\n") yaml.WriteString(" run: |\n") // Generate individual tool files (sorted by name for stable code generation) diff --git a/pkg/workflow/safe_jobs.go b/pkg/workflow/safe_jobs.go index 1eea746a78d..78103be063a 100644 --- a/pkg/workflow/safe_jobs.go +++ b/pkg/workflow/safe_jobs.go @@ -241,7 +241,7 @@ func (c *Compiler) buildSafeJobs(data *WorkflowData, threatDetectionEnabled bool agentOutputArtifactFilename := "${RUNNER_TEMP}/gh-aw/safe-jobs/" + constants.AgentOutputFilename // Add environment variables step with GH_AW_AGENT_OUTPUT and job-specific env vars - steps = append(steps, " - name: Setup Safe Job Environment Variables\n") + steps = append(steps, " - name: Configure Safe Job Environment Variables\n") steps = append(steps, " id: setup-safe-job-env\n") steps = append(steps, " run: |\n") steps = append(steps, " find \"${RUNNER_TEMP}/gh-aw/safe-jobs/\" -type f -print\n") @@ -256,7 +256,7 @@ func (c *Compiler) buildSafeJobs(data *WorkflowData, threatDetectionEnabled bool } // Add custom steps from the job configuration, injecting env vars from the - // "Setup Safe Job Environment Variables" step output so user steps can access them. + // "Configure Safe Job Environment Variables" step output so user steps can access them. if len(jobConfig.Steps) > 0 { // Build the env vars that were set in the setup step so we can inject them. setupEnvVars := map[string]string{ diff --git a/pkg/workflow/safe_scripts_test.go b/pkg/workflow/safe_scripts_test.go index e01ef51dfe6..615852289f5 100644 --- a/pkg/workflow/safe_scripts_test.go +++ b/pkg/workflow/safe_scripts_test.go @@ -265,7 +265,7 @@ func TestBuildCustomScriptFilesStep(t *testing.T) { fullYAML := strings.Join(steps, "") - assert.Contains(t, fullYAML, "Setup Safe Outputs Custom Scripts", "Should have setup step name") + assert.Contains(t, fullYAML, "Configure Safe Outputs Custom Scripts", "Should have configure step name") assert.Contains(t, fullYAML, "safe_output_script_my_handler.cjs", "Should reference the output filename") // Verify heredoc delimiter follows the randomized GH_AW_SAFE_OUTPUT_SCRIPT_MY_HANDLER__EOF format delimRE := regexp.MustCompile(`GH_AW_SAFE_OUTPUT_SCRIPT_MY_HANDLER_[0-9a-f]{16}_EOF`)