From 7ba1d23b0de591486c53483ecd19707c22c23b77 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 13 May 2026 00:25:46 +0000 Subject: [PATCH 1/4] Plan fix for centralized workflow compiler version metadata Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- .github/workflows/agentic_commands.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/agentic_commands.yml b/.github/workflows/agentic_commands.yml index 6f3632d5a1..63cbe7202f 100644 --- a/.github/workflows/agentic_commands.yml +++ b/.github/workflows/agentic_commands.yml @@ -1,4 +1,4 @@ -# gh-aw-commands: {"payload_version":"v1","schema_version":"v1","compiler_version":"v0.74.0-80-g12d56221e2","commands":["ace","approach-validator","archie","brave","cloclo","craft","grumpy","mergefest","nit","plan","poem-bot","review","security-review","summarize","tidy","unbloat"],"workflows":["ace-editor","approach-validator","archie","brave","cloclo","craft","grumpy-reviewer","mergefest","pdf-summary","plan","poem-bot","pr-code-quality-reviewer","pr-nitpick-reviewer","security-review","tidy","unbloat-docs"]} +# gh-aw-commands: {"payload_version":"v1","schema_version":"v1","compiler_version":"6fcd6e2","commands":["ace","approach-validator","archie","brave","cloclo","craft","grumpy","mergefest","nit","plan","poem-bot","review","security-review","summarize","tidy","unbloat"],"workflows":["ace-editor","approach-validator","archie","brave","cloclo","craft","grumpy-reviewer","mergefest","pdf-summary","plan","poem-bot","pr-code-quality-reviewer","pr-nitpick-reviewer","security-review","tidy","unbloat-docs"]} # ___ _ _ # / _ \ | | (_) # | |_| | __ _ ___ _ __ | |_ _ ___ From 7b098f8b7a28d2a7cd099a798d819f93b89ee713 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 13 May 2026 00:26:10 +0000 Subject: [PATCH 2/4] Use dev metadata for non-release centralized workflows Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- .../central_slash_command_workflow.go | 6 +++- .../central_slash_command_workflow_test.go | 35 ++++++++++++++++++- 2 files changed, 39 insertions(+), 2 deletions(-) diff --git a/pkg/workflow/central_slash_command_workflow.go b/pkg/workflow/central_slash_command_workflow.go index 1cfd4c4e0c..ed52367da6 100644 --- a/pkg/workflow/central_slash_command_workflow.go +++ b/pkg/workflow/central_slash_command_workflow.go @@ -208,10 +208,14 @@ func buildCommandsHeaderMetadata(routesByCommand map[string][]slashCommandRoute) workflows = append(workflows, workflowID) } sort.Strings(workflows) + compilerVersion := "dev" + if IsRelease() && strings.TrimSpace(GetVersion()) != "" { + compilerVersion = GetVersion() + } return commandsHeaderMetadata{ PayloadVersion: "v1", SchemaVersion: "v1", - Compiler: GetVersion(), + Compiler: compilerVersion, Commands: commands, Workflows: workflows, } diff --git a/pkg/workflow/central_slash_command_workflow_test.go b/pkg/workflow/central_slash_command_workflow_test.go index f45bdee269..5e8ff99878 100644 --- a/pkg/workflow/central_slash_command_workflow_test.go +++ b/pkg/workflow/central_slash_command_workflow_test.go @@ -16,6 +16,14 @@ import ( func TestGenerateCentralSlashCommandWorkflow_GeneratesWorkflow(t *testing.T) { tmpDir := testutil.TempDir(t, "central-slash-workflow-test") t.Setenv("GH_AW_ACTION_MODE", "dev") + originalVersion := compilerVersion + originalIsRelease := isReleaseBuild + t.Cleanup(func() { + compilerVersion = originalVersion + isReleaseBuild = originalIsRelease + }) + SetVersion("c610c2a") + SetIsRelease(false) data := []*WorkflowData{ { @@ -52,7 +60,7 @@ func TestGenerateCentralSlashCommandWorkflow_GeneratesWorkflow(t *testing.T) { require.NoError(t, json.Unmarshal([]byte(metadataJSON), &metadata)) require.Equal(t, "v1", metadata.PayloadVersion) require.Equal(t, "v1", metadata.SchemaVersion) - require.NotEmpty(t, metadata.Compiler) + require.Equal(t, "dev", metadata.Compiler) require.Equal(t, []string{"cloclo", "triage"}, metadata.Commands) require.Equal(t, []string{"cloclo", "triage-issue", "triage-pr"}, metadata.Workflows) @@ -184,6 +192,31 @@ func TestGenerateCentralSlashCommandWorkflow_UsesCentralizedRunsOnResolution(t * require.Contains(t, string(content), "runs-on: self-hosted") } +func TestBuildCommandsHeaderMetadata_UsesReleaseVersionOnlyForReleaseBuilds(t *testing.T) { + originalVersion := compilerVersion + originalIsRelease := isReleaseBuild + t.Cleanup(func() { + compilerVersion = originalVersion + isReleaseBuild = originalIsRelease + }) + + routesByCommand := map[string][]slashCommandRoute{ + "triage": { + {Workflow: "triage-issue", Events: []string{"issues"}}, + }, + } + + SetVersion("abc1234") + SetIsRelease(false) + metadata := buildCommandsHeaderMetadata(routesByCommand) + require.Equal(t, "dev", metadata.Compiler) + + SetVersion("v1.2.3") + SetIsRelease(true) + metadata = buildCommandsHeaderMetadata(routesByCommand) + require.Equal(t, "v1.2.3", metadata.Compiler) +} + func typeSetKeys(typeSet map[string]bool) []string { out := make([]string, 0, len(typeSet)) for key := range typeSet { From 74d9c2e57c7f3c29558801a88959a3173ce3cedb Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 13 May 2026 00:27:09 +0000 Subject: [PATCH 3/4] Normalize centralized workflow compiler metadata for dev builds Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- .github/workflows/agentic_commands.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/agentic_commands.yml b/.github/workflows/agentic_commands.yml index 63cbe7202f..07c4a60a94 100644 --- a/.github/workflows/agentic_commands.yml +++ b/.github/workflows/agentic_commands.yml @@ -1,4 +1,4 @@ -# gh-aw-commands: {"payload_version":"v1","schema_version":"v1","compiler_version":"6fcd6e2","commands":["ace","approach-validator","archie","brave","cloclo","craft","grumpy","mergefest","nit","plan","poem-bot","review","security-review","summarize","tidy","unbloat"],"workflows":["ace-editor","approach-validator","archie","brave","cloclo","craft","grumpy-reviewer","mergefest","pdf-summary","plan","poem-bot","pr-code-quality-reviewer","pr-nitpick-reviewer","security-review","tidy","unbloat-docs"]} +# gh-aw-commands: {"payload_version":"v1","schema_version":"v1","compiler_version":"dev","commands":["ace","approach-validator","archie","brave","cloclo","craft","grumpy","mergefest","nit","plan","poem-bot","review","security-review","summarize","tidy","unbloat"],"workflows":["ace-editor","approach-validator","archie","brave","cloclo","craft","grumpy-reviewer","mergefest","pdf-summary","plan","poem-bot","pr-code-quality-reviewer","pr-nitpick-reviewer","security-review","tidy","unbloat-docs"]} # ___ _ _ # / _ \ | | (_) # | |_| | __ _ ___ _ __ | |_ _ ___ From 4e249e770885027c353ac82175f00397a7b5d528 Mon Sep 17 00:00:00 2001 From: Peli de Halleux Date: Tue, 12 May 2026 17:46:06 -0700 Subject: [PATCH 4/4] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- pkg/workflow/central_slash_command_workflow.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/workflow/central_slash_command_workflow.go b/pkg/workflow/central_slash_command_workflow.go index ed52367da6..31b64abf7d 100644 --- a/pkg/workflow/central_slash_command_workflow.go +++ b/pkg/workflow/central_slash_command_workflow.go @@ -208,14 +208,14 @@ func buildCommandsHeaderMetadata(routesByCommand map[string][]slashCommandRoute) workflows = append(workflows, workflowID) } sort.Strings(workflows) - compilerVersion := "dev" + metadataCompilerVersion := "dev" if IsRelease() && strings.TrimSpace(GetVersion()) != "" { - compilerVersion = GetVersion() + metadataCompilerVersion = GetVersion() } return commandsHeaderMetadata{ PayloadVersion: "v1", SchemaVersion: "v1", - Compiler: compilerVersion, + Compiler: metadataCompilerVersion, Commands: commands, Workflows: workflows, }