Add success check-run publishing to reviewer workflows#34025
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Enable success check runs for PR reviewer workflows
Add success check-run publishing to reviewer workflows
May 22, 2026
Copilot created this pull request from a session on behalf of
pelikhan
May 22, 2026 14:17
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Wires AI reviewer workflows to optionally publish a “success” GitHub check run when the final review verdict is clean, so approved reviews can surface a green check in the PR UI.
Changes:
- Adds
create-check-runto the shared PR review safe-outputs configuration and documents intended usage on approve. - Recompiles multiple reviewer
.lock.ymlworkflows to includecreate_check_runin safe-output tooling/config and grantschecks: writewhere needed. - Updates action pin data and the release workflow to use a pinned SHA for
docker/metadata-actionsourced from@v6.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/data/action_pins.json | Adds a pinned entry for docker/metadata-action@v6. |
| pkg/actionpins/data/action_pins.json | Mirrors the new docker/metadata-action@v6 pin in the actionpins package copy. |
| .github/aw/actions-lock.json | Updates the repo-level actions lock data with the new docker/metadata-action@v6 pin. |
| .github/workflows/shared/pr-code-review-config.md | Enables create-check-run safe-output for reviewer bases and adds guidance text. |
| .github/workflows/security-review.lock.yml | Allows create_check_run safe output and adds checks: write permission. |
| .github/workflows/release.lock.yml | Switches docker/metadata-action usage to the newly pinned @v6 SHA. |
| .github/workflows/refiner.lock.yml | Allows create_check_run safe output and adds checks: write permission. |
| .github/workflows/pr-triage-agent.lock.yml | Allows create_check_run safe output and adds checks: write permission. |
| .github/workflows/pr-nitpick-reviewer.lock.yml | Allows create_check_run safe output and adds checks: write permission. |
| .github/workflows/pr-code-quality-reviewer.lock.yml | Allows create_check_run safe output and adds checks: write permission. |
| .github/workflows/mattpocock-skills-reviewer.md | Updates reviewer instructions to require a success check run on approve. |
| .github/workflows/mattpocock-skills-reviewer.lock.yml | Allows create_check_run safe output and adds checks: write permission. |
| .github/workflows/grumpy-reviewer.lock.yml | Allows create_check_run safe output and adds checks: write permission. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
.github/workflows/shared/pr-code-review-config.md:37
- In this document the safe-output identifiers are listed with hyphens (e.g.
create-pull-request-review-comment,submit-pull-request-review), but this new entry uses the underscore tool namecreate_check_run. Please make the naming consistent (either document the hyphenated safe-output keycreate-check-runor switch all entries to underscore tool names). Also,create_check_runrequires bothtitleandsummaryfields (perpkg/workflow/js/safe_outputs_tools.json), so the guidance should mention providing a title as well as a summary.
- `create-pull-request-review-comment` — Post inline comments on specific lines
- `submit-pull-request-review` — Submit the overall review (APPROVE / REQUEST_CHANGES / COMMENT)
- `create_check_run` — When the final verdict is `APPROVE`, create one check run with `conclusion: "success"` summarizing that no blocking issues were found
- Files reviewed: 13/13 changed files
- Comments generated: 2
Comment on lines
+15
to
+16
| create-check-run: | ||
| max: 1 |
| - **`APPROVE`** — Changes are solid; only minor suggestions | ||
| - **`REQUEST_CHANGES`** — There are important issues that should be addressed | ||
| - **`COMMENT`** — Observations only; no blocking issues | ||
| - If you choose **`APPROVE`**, also call `create_check_run` with `conclusion: "success"` and a short summary that no blocking issues were found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer workflows currently complete with review comments/verdicts but do not always emit a green check when the review outcome is clean. This update wires reviewer flows (including Matt Pocock reviewer) to publish a success check run when no blocking issues are found.
What changed
create-check-runto the shared PR review safe-output config (shared/pr-code-review-config.md) so reviewer workflows importing the shared base can emit check runs.create_check_runwithconclusion: "success"when verdict isAPPROVE.mattpocock-skills-reviewer.mdinstructions to require a success check run on approve.Scope impact
shared/pr-review-base.md(e.g., code-quality, nitpick, grumpy, triage, security, refiner, Matt Pocock reviewer).