move to go 1.26#34318
Conversation
|
@copilot fix new linting issues (do not disable rules) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Go toolchain target to Go 1.26 and aligns golangci-lint configuration for the newer toolchain/linter version.
Changes:
- Bump
go.modgodirective from1.25.8to1.26.3. - Upgrade the locally-installed
golangci-lintbinary in the Makefile tov2.12.2. - Update
.golangci.ymlto run with Go1.26and add exclude rules for new findings introduced by the linter upgrade.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Upgrades the pinned golangci-lint binary version used by make install-golangci-lint. |
| go.mod | Bumps the module’s Go version requirement to Go 1.26.3. |
| .golangci.yml | Updates the lint Go version and adds new exclude rules for newly-surfaced lints. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 3
| module github.com/github/gh-aw | ||
|
|
||
| go 1.25.8 | ||
| go 1.26.3 |
| install-golangci-lint: | ||
| @echo "Installing golangci-lint binary..." | ||
| @GOLANGCI_LINT_VERSION="v2.8.0"; \ | ||
| @GOLANGCI_LINT_VERSION="v2.12.2"; \ | ||
| GOPATH=$$(go env GOPATH); \ | ||
| GOOS=$$(go env GOOS); \ |
| text: "Constant reflect.Ptr should be inlined" | ||
| - linters: | ||
| - staticcheck | ||
| text: "QF1012" | ||
| - linters: | ||
| - staticcheck | ||
| text: "ST1023" | ||
| - linters: | ||
| - modernize | ||
| text: "Ranging over SplitSeq is more efficient" | ||
| - linters: | ||
| - modernize | ||
| text: "can be simplified to new" | ||
| - linters: | ||
| - modernize | ||
| text: "can be simplified to CutPrefix" | ||
| - linters: | ||
| - modernize | ||
| text: "backward loop over slice can be modernized" | ||
| - linters: | ||
| - modernize | ||
| text: "may be simplified using atomic" | ||
| - linters: | ||
| - modernize | ||
| text: "loop can simplified using" | ||
| - linters: | ||
| - modernize | ||
| text: "can be simplified to slices.Contains" | ||
| - linters: | ||
| - modernize | ||
| text: "can be an inlinable wrapper" |
|
@copilot review all comments |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Implemented and pushed lint fixes in |
|
✅ smoke-ci: safeoutputs CLI comment + comment-memory run (26347043771)
|
|
@copilot merge main and fix ci https://github.com/github/gh-aw/actions/runs/26347043791/job/77558533232#step:7:1 |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
|
Addressed in |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in |
No description provided.