Disable npm release-age cooldown for Claude, Codex, and Gemini engine installs#34338
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Disable cooldown for Claude, Codex, and Gemini installs
Disable npm release-age cooldown for Claude, Codex, and Gemini engine installs
May 24, 2026
Copilot created this pull request from a session on behalf of
pelikhan
May 24, 2026 01:14
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Removes npm’s default release-age cooldown behavior (NPM_CONFIG_MIN_RELEASE_AGE) from the Claude, Codex, and Gemini engine installation paths so agentic engine CLIs can be installed immediately when needed, while keeping the runtime-level cooldown mechanism available for other installs.
Changes:
- Added a no-cooldown npm engine install helper and refactored the standard helper to route through a shared internal builder with an explicit
cooldownEnabledtoggle. - Updated Claude/Codex/Gemini installation code to ensure
NPM_CONFIG_MIN_RELEASE_AGEis not set for those engine installs. - Expanded tests to assert cooldown env omission; recompiled
avenger.lock.ymlto reflect the updated Claude install behavior.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/nodejs.go | Refactors standard npm engine install-step construction and adds a no-cooldown variant. |
| pkg/workflow/gemini_engine.go | Switches Gemini engine installs to the no-cooldown helper. |
| pkg/workflow/gemini_engine_test.go | Asserts Gemini install steps do not include NPM_CONFIG_MIN_RELEASE_AGE. |
| pkg/workflow/engine_helpers_test.go | Adds coverage for the no-cooldown helper behavior. |
| pkg/workflow/codex_engine.go | Switches Codex engine installs to the no-cooldown helper. |
| pkg/workflow/codex_engine_test.go | Asserts Codex install steps do not include NPM_CONFIG_MIN_RELEASE_AGE. |
| pkg/workflow/claude_engine.go | Forces cooldown off for Claude CLI install steps. |
| pkg/workflow/claude_engine_test.go | Asserts Claude install steps do not include NPM_CONFIG_MIN_RELEASE_AGE. |
| .github/workflows/avenger.lock.yml | Recompiled workflow output reflecting the updated Claude installation behavior. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 9/9 changed files
- Comments generated: 2
Comment on lines
+55
to
+56
| if strings.Contains(strings.Join([]string(steps[1]), "\n"), "NPM_CONFIG_MIN_RELEASE_AGE") { | ||
| t.Errorf("Expected no npm release-age cooldown env for Codex install, got '%s'", strings.Join([]string(steps[1]), "\n")) |
Comment on lines
+84
to
+88
| steps := BuildStandardNpmEngineInstallStepsNoCooldown( | ||
| "@openai/codex", | ||
| string(constants.DefaultCodexVersion), | ||
| "Install Codex CLI", | ||
| "codex", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agentic engine installs were still applying npm’s default release-age cooldown, which can delay installation of required CLI versions. This change removes cooldown behavior for Claude, Codex, and Gemini installation paths while leaving runtime-level cooldown behavior available where still intended.
Installation behavior
Shared install helper
BuildStandardNpmEngineInstallStepsNoCooldown(...)inpkg/workflow/nodejs.go.cooldownEnabledcontrol.Coverage updates
NPM_CONFIG_MIN_RELEASE_AGEis absent for Claude, Codex, and Gemini installs.Compiled workflow output
avenger.lock.ymlso generated workflow output matches updated Claude install step behavior.