Refactor ResolveActionPin into focused resolution phases#34361
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor long functions in pkg/workflow and pkg/actionpins
Refactor May 24, 2026
ResolveActionPin into focused resolution phases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/workflowandpkg/actionpinshave significant long-function lint debt; this PR addresses thepkg/actionpinsportion by reducingResolveActionPincomplexity without changing its external contract. The pin-resolution path is now split into explicit phases to make behavior easier to reason about and extend.What changed
tryDynamicActionResolution(...).resolveFromHardcodedPins(...).resolveMissingActionPin(...).ResolveActionPin(...)as a compact orchestrator over those phases.Behavior preserved
ctx.Warnings) and resolution-failure recording behavior.FormatPinnedActionReference/formatPinnedActionWithResolution) and SHA handling.Resulting structure
ResolveActionPinnow delegates instead of inlining all branches, reducing line count and isolating responsibilities.