Defer file closes in pkg/cli workflow readers and logs cache writer#34372
Draft
Copilot wants to merge 2 commits into
Draft
Defer file closes in pkg/cli workflow readers and logs cache writer#34372Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
6 tasks
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix resource management for deferred file close
Defer file closes in pkg/cli workflow readers and logs cache writer
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LintMonster flagged three
os.Open/os.OpenFilecall sites inpkg/cliwhereClose()was not deferred immediately after a successful open, leaving room for descriptor leaks on early returns.Workflow file readers
filterMarkdownFilesWithFrontmatterto read each file inside a narrow helper scope and deferfd.Close()immediately afteros.Open.extractWorkflowNameFromFileto use a deferred close while preserving the existing close-error propagation.MCP logs cache writer
buildLogsFileResponseto write through a small scoped helper that defersf.Close()immediately afteros.OpenFile.Error handling shape
Close()calls.Example pattern applied: