Skip to content

Annotate resolve_transport_paths with SEC-005 exemption to avoid false cross-repo validation failure#37560

Merged
pelikhan merged 2 commits into
mainfrom
copilot/sec-005-add-allowlist-check
Jun 7, 2026
Merged

Annotate resolve_transport_paths with SEC-005 exemption to avoid false cross-repo validation failure#37560
pelikhan merged 2 commits into
mainfrom
copilot/sec-005-add-allowlist-check

Conversation

Copilot AI commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

SEC-005 flagged actions/setup/js/resolve_transport_paths.cjs for missing target-repo allowlist checks due to heuristic matching on defaultTargetRepo. This utility does not perform cross-repository API writes; it only derives local transport file paths and checks existence.

  • Conformance alignment

    • Added a documented SEC-005 exemption annotation in resolve_transport_paths.cjs to mark the module as a pure local path-derivation utility.
    • Clarified that target-repo allowlist enforcement is owned by upstream API-calling handlers.
  • Behavioral impact

    • No runtime logic changes.
    • No changes to path derivation, repo candidate selection, or file resolution behavior.
// @safe-outputs-exempt SEC-005: pure local path-derivation utility; no cross-repo API calls. Target-repo allowlist enforcement is handled upstream in API-calling handlers.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Add allowlist check to resolve_transport_paths.cjs for SEC-005 conformance Annotate resolve_transport_paths with SEC-005 exemption to avoid false cross-repo validation failure Jun 7, 2026
Copilot AI requested a review from pelikhan June 7, 2026 13:32
@pelikhan pelikhan marked this pull request as ready for review June 7, 2026 13:36
Copilot AI review requested due to automatic review settings June 7, 2026 13:36
@pelikhan pelikhan merged commit d826bd9 into main Jun 7, 2026
@pelikhan pelikhan deleted the copilot/sec-005-add-allowlist-check branch June 7, 2026 13:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a SEC-005 exemption annotation to resolve_transport_paths.cjs so safe-outputs conformance tooling doesn’t misclassify this local path-derivation helper as a cross-repo operation requiring an allowlist check.

Changes:

  • Annotated actions/setup/js/resolve_transport_paths.cjs with @safe-outputs-exempt SEC-005 and a rationale indicating it performs only local path derivation/existence checks.
  • No runtime behavior or path-derivation logic changes.
Show a summary per file
File Description
actions/setup/js/resolve_transport_paths.cjs Adds a SEC-005 exemption annotation to prevent false-positive cross-repo validation findings for a local-only utility.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Safe Outputs Conformance] SEC-005: resolve_transport_paths.cjs supports target-repo but lacks allowlist check

3 participants