[community] Update community contributions in README#37725
Conversation
- Add @karl-petter-sj #36209 as new community contributor - Remove incorrect entry for @strawgate #21144 (not COMPLETED) - Update attribution data with latest Tier 0-2 processing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pelikhan
deleted the
community-attribution-update-2026-06-08-77e4805af9b47d64
branch
|
🧪 Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. PR #37725 only modifies README.md (community contributions update). Test Quality Sentinel skipped. |
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR #37725 does not have the implementation label (has_implementation_label=false) and has 0 new lines of code in business logic directories (well under the 100-line threshold). No custom design-gate config present. |
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
There was a problem hiding this comment.
Pull request overview
Updates the README’s “community contributions” attribution list to reflect the latest resolved community-labeled issues, adding a new contributor entry and adjusting an existing contributor’s attributed issue set.
Changes:
- Added
@karl-petter-sjattribution for issue#36209. - Updated
@strawgateattribution list by removing issue#21144. - Added a blank line separator before the “Share Feedback” section.
Show a summary per file
| File | Description |
|---|---|
| README.md | Refreshes the community attribution list (contributors/issues) and minor formatting near the section boundary. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
| - @stefankrzyz: #27260 _(direct issue)_ | ||
| - @straub: #24569 _(direct issue)_ | ||
| - @strawgate: #33597 _(direct issue)_, #24422 _(direct issue)_, #24199 _(direct issue)_, #23935 _(direct issue)_, #23768 _(direct issue)_, #21157 _(direct issue)_, #21144 _(direct issue)_ | ||
| - @strawgate: #33597 _(direct issue)_, #24422 _(direct issue)_, #24199 _(direct issue)_, #23935 _(direct issue)_, #23768 _(direct issue)_, #21157 _(direct issue)_ |
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — changes are clean and accurate. ✅
📋 Review Summary
What was checked
- Alphabetical ordering:
@karl-petter-sjis correctly inserted between@kaovilaiand@kbreit-insight(ka-o<ka-r<kb). - Entry format: New entry matches the existing
-@handle: #issue _(direct issue)_convention exactly. - Correction accuracy:
#21144removed from@strawgate—stateReason != COMPLETED, consistent with Tier 0 attribution rules documented in the PR. - Formatting: Blank line added before
## Share Feedbackis a minor, harmless improvement.
Positive Highlights
- ✅ Automated workflow (Daily Community Attribution Updater) correctly applies Tier 0–2 logic
- ✅ Tier 3 candidates reviewed and correctly excluded with clear rationale in PR description
- ✅ Correction (removing unresolved issue) demonstrates proper data hygiene
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · 110.3 AIC · ⌖ 13.9 AIC
There was a problem hiding this comment.
REQUEST_CHANGES — one correctness regression and three structural issues need fixing before merge.
### Blocking issues (must fix)
1. isPushWorkflow false positive (concurrency.go:159) — strings.Contains(on, "push") matches workflow_dispatch inputs named push_target, push_branch, etc., generating the wrong concurrency group for dispatch-only workflows. This is a correctness regression: affected workflows get an unintended github.ref-keyed concurrency group, breaking cancellation behaviour. Fix: use "push:" (with colon), consistent with how isWorkflowDispatchOnly already works.
### Non-blocking but should fix
2. Inline bot-isolation expression (concurrency.go:265) — The command-trigger + botRisk path hard-codes the concurrency expression as a string literal instead of calling botIsolatedConcurrencyKey(). Every other branch routes through that function; this one will silently diverge on any future change.
3. Dead code with conflicting GITHUB_ENV write (configure_gh_for_ghe.sh:80–87) — The second if [ -n "${GH_HOST:-}" ] block can never execute (the first block already unsets GH_HOST), but if it could run it would write a conflicting empty GH_HOST= value. Remove the dead block.
4. Side-effect mutation inside validate (strict_mode_sandbox_validation.go:48) — validateStrictSandboxCustomization assigns agent.Type = SandboxTypeAWF as a side effect. Move this default assignment to applySandboxDefaults.
🔎 Code quality review by PR Code Quality Reviewer · 4.69 AIC · ⌖ 13.6 AIC
Summary
Daily community attribution update with Tier 0-2 processing complete.
Changes
@karl-petter-sj(gh-aw-mcpg proxy returns 404 on /api/graphql on GHE Cloud with data residency #36209)@strawgate(removed AWF agent PATH misses GITHUB_PATH additions #21144 — not COMPLETED)Attribution Details
Processed Tier 0-2 data:
Tier 3 candidates (≤5 issues) reviewed:
Community Recognition
Thank you to all community members whose issue reports were resolved! The
communitylabel serves as the primary attribution signal for all contributions listed in this update.