From f73dd481fa4c828504b566fb73ae113c182d7800 Mon Sep 17 00:00:00 2001 From: Jan Grodowski Date: Tue, 19 May 2026 16:07:46 +0200 Subject: [PATCH] Do not report extremely high HeartbeatLag values until the first heartbeat is read --- go/logic/migrator.go | 2 ++ go/logic/migrator_test.go | 2 ++ 2 files changed, 4 insertions(+) diff --git a/go/logic/migrator.go b/go/logic/migrator.go index aaacbdd2e..ac5b7fc71 100644 --- a/go/logic/migrator.go +++ b/go/logic/migrator.go @@ -450,6 +450,7 @@ func (mgtr *Migrator) checkAbort() error { func (mgtr *Migrator) Migrate() (err error) { mgtr.migrationContext.Log.Infof("Migrating %s.%s", sql.EscapeName(mgtr.migrationContext.DatabaseName), sql.EscapeName(mgtr.migrationContext.OriginalTableName)) mgtr.migrationContext.StartTime = time.Now() + mgtr.migrationContext.SetLastHeartbeatOnChangelogTime(mgtr.migrationContext.StartTime) // Ensure context is cancelled on exit (cleanup) defer mgtr.migrationContext.CancelContext() @@ -667,6 +668,7 @@ func (mgtr *Migrator) Revert() error { sql.EscapeName(mgtr.migrationContext.DatabaseName), sql.EscapeName(mgtr.migrationContext.OriginalTableName), sql.EscapeName(mgtr.migrationContext.DatabaseName), sql.EscapeName(mgtr.migrationContext.OldTableName)) mgtr.migrationContext.StartTime = time.Now() + mgtr.migrationContext.SetLastHeartbeatOnChangelogTime(mgtr.migrationContext.StartTime) // Ensure context is cancelled on exit (cleanup) defer mgtr.migrationContext.CancelContext() diff --git a/go/logic/migrator_test.go b/go/logic/migrator_test.go index 7a1bcb48f..8fc48e326 100644 --- a/go/logic/migrator_test.go +++ b/go/logic/migrator_test.go @@ -990,6 +990,7 @@ func (suite *MigratorTestSuite) TestRevertEmpty() { err = migrator.Migrate() oldTableName = migrationContext.GetOldTableName() suite.Require().NoError(err) + suite.Require().Less(migrationContext.TimeSinceLastHeartbeatOnChangelog(), 24*time.Hour) } // revert the original migration @@ -1008,6 +1009,7 @@ func (suite *MigratorTestSuite) TestRevertEmpty() { err = migrator.Revert() suite.Require().NoError(err) + suite.Require().Less(migrationContext.TimeSinceLastHeartbeatOnChangelog(), 24*time.Hour) } }