From db1edbabe0466981c7597c46d7401c9bfd457e67 Mon Sep 17 00:00:00 2001 From: JoannaaKL Date: Thu, 28 May 2026 19:34:05 +0200 Subject: [PATCH 1/2] I want to enable only ifc --- pkg/github/feature_flags.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/github/feature_flags.go b/pkg/github/feature_flags.go index 6f04be7f1..0f77f6c87 100644 --- a/pkg/github/feature_flags.go +++ b/pkg/github/feature_flags.go @@ -23,6 +23,7 @@ const FeatureFlagIssueFields = "remote_mcp_issue_fields" var AllowedFeatureFlags = []string{ MCPAppsFeatureFlag, FeatureFlagCSVOutput, + FeatureFlagIFCLabels, FeatureFlagIssueFields, FeatureFlagIssuesGranular, FeatureFlagPullRequestsGranular, From 855857e239ce0d728c62df0e400cba7542fecaa0 Mon Sep 17 00:00:00 2001 From: JoannaaKL Date: Thu, 28 May 2026 19:39:34 +0200 Subject: [PATCH 2/2] Fix tests --- pkg/github/feature_flags_test.go | 7 +++---- pkg/http/server_test.go | 6 ------ 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/pkg/github/feature_flags_test.go b/pkg/github/feature_flags_test.go index 9f31ada38..3f9d21195 100644 --- a/pkg/github/feature_flags_test.go +++ b/pkg/github/feature_flags_test.go @@ -148,7 +148,7 @@ func TestResolveFeatureFlags(t *testing.T) { name: "no features, no insiders", enabledFeatures: nil, expectedFlags: nil, - unexpectedFlags: []string{MCPAppsFeatureFlag, FeatureFlagIFCLabels}, + unexpectedFlags: []string{MCPAppsFeatureFlag}, }, { name: "explicit feature enabled", @@ -168,10 +168,9 @@ func TestResolveFeatureFlags(t *testing.T) { expectedFlags: []string{FeatureFlagIFCLabels}, }, { - name: "internal-only flags are not directly enabled", + name: "ifc_labels can be directly enabled", enabledFeatures: []string{FeatureFlagIFCLabels}, - expectedFlags: nil, - unexpectedFlags: []string{FeatureFlagIFCLabels}, + expectedFlags: []string{FeatureFlagIFCLabels}, }, { name: "unknown flags are filtered out", diff --git a/pkg/http/server_test.go b/pkg/http/server_test.go index 5458a6b39..62511775a 100644 --- a/pkg/http/server_test.go +++ b/pkg/http/server_test.go @@ -87,12 +87,6 @@ func TestCreateHTTPFeatureChecker(t *testing.T) { headerFeatures: []string{github.FeatureFlagIssuesGranular}, wantEnabled: true, }, - { - name: "internal-only flag in header is ignored", - flagName: github.FeatureFlagIFCLabels, - headerFeatures: []string{github.FeatureFlagIFCLabels}, - wantEnabled: false, - }, { name: "static insiders enables insiders flags without route context", staticInsiders: true,