Send all events to Jaconda #206

Merged
merged 1 commit into from Jan 24, 2012

Conversation

Projects
None yet
2 participants
Contributor

mironov commented Dec 21, 2011

No description provided.

Contributor

technoweenie commented Dec 29, 2011

Hi, we're going to have to hold off on this for a bit. Our hooks server is getting a bit overloaded. I have some fixes I need to implement first.

technoweenie added a commit that referenced this pull request Jan 24, 2012

Merge pull request #206 from mironov/master
Send all events to Jaconda

@technoweenie technoweenie merged commit c84eae4 into github:master Jan 24, 2012

Contributor

technoweenie commented Jan 24, 2012

Please run tests before submitting code.

Contributor

mironov commented Jan 28, 2012

Sorry, didn't know that tests for Jaconda integration even exist.
Thanks for the merge.

Contributor

mironov commented Jan 28, 2012

Is this deployed yet?
Don't see any events besides push-events on Jaconda side.

Contributor

technoweenie commented Jan 28, 2012

Yes it's deployed. Users will have to recreate the hooks to take effect, as it only affects new hooks.

Contributor

mironov commented Jan 29, 2012

Sorry for being annoying.
I've created a special repo under my account, called test_hooks, and enabled there Jaconda integration.
But I am still seeing only requests with push events, there are no requests with new issues or issue comments.
What am I doing wrong?

Contributor

technoweenie commented Jan 29, 2012

Check the hook config through the api:

https://api.github.com/mironov/test_hooks/hooks/158767

You should see these listed events:

["commit_comment", "download", "fork", "fork_apply", "gollum",
"issues", "issue_comment", "member", "public", "pull_request", "push",
"watch"]

Contributor

technoweenie commented Jan 29, 2012

I set up a post-receive hook with the same events.

$ curl -in https://api.github.com/repos/github/github-services/hooks/143076
HTTP/1.1 200 OK
Server: nginx/1.0.4
Date: Sun, 29 Jan 2012 19:05:12 GMT
Content-Type: application/json; charset=utf-8
Connection: keep-alive
Status: 200 OK
ETag: "f49a4a76a5312e03db41293a3a19c5e0"
Content-Length: 617

{
  "updated_at": "2012-01-29T19:04:37Z",
  "created_at": "2012-01-05T18:04:35Z",
  "events": [
    "commit_comment",
    "download",
    "fork",
    "fork_apply",
    "gollum",
    "issues",
    "issue_comment",
    "member",
    "public",
    "pull_request",
    "push",
    "watch"
  ]

Here's the result of my previous comment: http://requestb.in/y0xlp1y0?inspect#16k5g0

That hook goes through the Web Service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment