campfire: allow configuring the sound to play #276

Merged
merged 1 commit into from Apr 11, 2012

Conversation

Projects
None yet
2 participants
@tomjack
Contributor

tomjack commented Apr 3, 2012

I would have gotten rid of play_sound and just not played a sound when data['sound'] is blank, but I left it so that people don't suddenly stop getting rimshots. Not sure what goes on behind the scenes here...

technoweenie added a commit that referenced this pull request Apr 11, 2012

Merge pull request #276 from tomo/campfire-sounds
campfire: allow configuring the sound to play

@technoweenie technoweenie merged commit f69c6e5 into github:master Apr 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment