Add branch regex to irc client #283

Merged
merged 2 commits into from Apr 18, 2012

Conversation

Projects
None yet
2 participants
Contributor

jeffweiss commented Apr 11, 2012

Prior to this commit, the IRC service would dutifully notify you of
every push to every branch. This allows you to limit, via
comma-separated regexes, which branches will notify via IRC.

NOTE: It's possible that a , separated list of regexes could cause
problems if people want to use a , in the regex. If this is an issue,
I'll add a field to specify the delimiter.

Jeff Weiss added some commits Apr 11, 2012

Jeff Weiss Add branch regex filter for IRC client
Prior to this commit, the IRC service would dutifully notify you of
every push to every branch. This allows you to limit, via
comma-separated regexes, which branches will notify via IRC.
5dfdb9d
Jeff Weiss Add branch regex filter for IRC client
Add tests for regex filter for IRC client.
Fix edge case of existing, but empty regex filter.
59bec11

@technoweenie technoweenie added a commit that referenced this pull request Apr 18, 2012

@technoweenie technoweenie Merge pull request #283 from jeffweiss/patch/master/add_branch_regex_…
…to_irc_client

Add branch regex to irc client
ac98e69

@technoweenie technoweenie merged commit ac98e69 into github:master Apr 18, 2012

Member

technoweenie commented Apr 20, 2012

You should see the new field available on the form now. Let me know if you have any problems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment