New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a switch to send full commit messages to the CIA service hook #392

Merged
merged 1 commit into from Sep 11, 2012

Conversation

Projects
None yet
2 participants
@shikadiqueen
Contributor

shikadiqueen commented Sep 3, 2012

Many people prefer to format their Git commit messages like emails for
various reasons, and the current CIA hook used at Github only sends the
first (subject) line of each message to the CIA server every time, thus
forcing people to either break convention by squashing all the important
bits in the same single line, or click on the included link every time
to see the full message.

The CIA bots do their own filtering to ensure they don't flood IRC
channels with long commit messages, so this shouldn't really be the
commit hook's responsibility.

However, some people might still prefer to see only the subject lines on
their channels. Thus, an additional full commit messages option is
provided in this commit for the benefit of both camps.

Add a switch to send full commit messages to the CIA service hook
Many people prefer to format their Git commit messages like emails for
various reasons, and the current CIA hook used at Github only sends the
first (subject) line of each message to the CIA server every time, thus
forcing people to either break convention by squashing all the important
bits in the same single line, or click on the included link every time
to see the full message.

The CIA bots do their own filtering to ensure they don't flood IRC
channels with long commit messages, so this shouldn't really be the
commit hook's responsibility.

However, some people might still prefer to see only the subject lines on
their channels. Thus, an additional full commit messages option is
provided in this commit for the benefit of both camps.

technoweenie added a commit that referenced this pull request Sep 11, 2012

Merge pull request #392 from shikadilord/feature/cia-full-commits-option
Add a switch to send full commit messages to the CIA service hook

@technoweenie technoweenie merged commit 2ce7838 into github:master Sep 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment