Add restrict_to_branch support to hipchat script #481

Merged
merged 1 commit into from Dec 30, 2012

Conversation

Projects
None yet
6 participants
Contributor

ferlores commented Dec 30, 2012

It restricts the notifications to an optional list of branches. It will be necessary to change the UI (like for example in the asana hook)

Contributor

ferlores commented Dec 30, 2012

woloski commented Dec 30, 2012

👍

technoweenie merged commit 8010004 into github:master Dec 30, 2012

Member

technoweenie commented Dec 30, 2012

test_push(HipChatTest):
NoMethodError: private method `split' called for nil:NilClass
    /var/lib/jenkins/workspace/a53dca0c61c92e1a4eef6ba71062942d/lib/service/../../services/hipchat.rb:14:in `receive_event'
    /var/lib/jenkins/workspace/a53dca0c61c92e1a4eef6ba71062942d/test/hip_chat_test.rb:18:in `test_push'

Send tests next time :)

Contributor

ferlores commented Dec 30, 2012

Upss. Thanks for fixing it :D

Contributor

powdahound commented Dec 30, 2012

👍

Contributor

powdahound commented Jan 2, 2013

FYI, I think this change broke all non-push events. I suspect its because it's trying to use payload['ref'] which doesn't always exist. Fighting through some ruby/rvm issues now so I can test my changes and will submit a pull after.

Contributor

ferlores commented Jan 2, 2013

@powdahound you are right. I was aware of that but I'm not strong in ruby for this change. Actually i would like also to receive notifications if I get a Pull Request over the selected branch

@powdahound powdahound added a commit to powdahound/github-services that referenced this pull request Jan 2, 2013

@powdahound powdahound HipChat: Only check branch restriction on pushes
Issue introduced by #481
3644bfd

Is there any way to have fuzzy matching on branch names? For eg. projectteam1

iwein commented Nov 25, 2013

Any chance we can get some examples in the docs? I'm not sure what separators are allowed, if I can use wildcards, that sort of thing. "master, develop" or "master develop"? "master hotfixes/*"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment