Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add an API Key to the tenXer service #542

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

kdeggelman commented Mar 8, 2013

This will allow for better authentication between the service and our endpoint.

bizrad6 commented on ae33b3f Mar 8, 2013

approved

Member

technoweenie commented Mar 11, 2013

Won't this break existing hooks that don't have an API key? Or have they always been broken?

Contributor

kdeggelman commented Mar 11, 2013

Our backend doesn't require an API key (yet). We are migrating from the generic webhook service to our own service. Once this pull request gets merged, and is live on github.com we will run a migration to automatically add an API key to the repositories that use our old webhook.

@technoweenie technoweenie commented on an outdated diff Mar 11, 2013

lib/services/tenxer.rb
def receive_event
+ # make sure we have what we need
+ raise_config_error "Missing 'api_key'" if data['api_key'].to_s == ''
@technoweenie

technoweenie Mar 11, 2013

Member

Maybe take this out until API keys are set on all the hooks. Otherwise as soon as this gets deployed to our servers, we will start start dropping all tenxer hooks.

Member

technoweenie commented Apr 22, 2013

Can re-apply this in a new PR against the current 'master' branch on github-services? Your fork's master branch is very outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment