New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send pull_request_review_comment events to HipChat #695

Merged
merged 1 commit into from Sep 20, 2013

Conversation

Projects
None yet
4 participants
@powdahound
Copy link
Contributor

powdahound commented Sep 20, 2013

We support them, but they weren't being sent. :(

@atmos

This comment has been minimized.

Copy link
Contributor

atmos commented Sep 20, 2013

Is this something that users configure or will it open the flood gates and existing customers will start getting events for all these new events? We don't get chat notifications for these in our rooms intentionally.

@powdahound

This comment has been minimized.

Copy link
Contributor

powdahound commented Sep 20, 2013

It'd open up the flood gates. We've had quite a few people let us know that they were 'broken' lately , but I'm not sure how many people would be upset about the new notifications.

Are you guys still considering adding options to all webhooks to let people configure which events are active? If not, I could add another option to this service (we already have a few).

@atmos

This comment has been minimized.

Copy link
Contributor

atmos commented Sep 20, 2013

We could change it to be an event that it does respond to without making it a default and people could configure it via the API. There's some barrier to entry on that approach though.

@technoweenie

This comment has been minimized.

Copy link
Contributor

technoweenie commented Sep 20, 2013

FWIW there is a quiet comment checkbox.

Also, this change won't retroactively edit anyone's existing hook configs. This default is only applied when a hook is created.

atmos added a commit that referenced this pull request Sep 20, 2013

Merge pull request #695 from powdahound/master
Send pull_request_review_comment events to HipChat

@atmos atmos merged commit 9f3853a into github:master Sep 20, 2013

@atmos

This comment has been minimized.

Copy link
Contributor

atmos commented Sep 20, 2013

Word, I'm about to head out for the weekend but I should be able to cut a release with these changes on monday.

@powdahound

This comment has been minimized.

Copy link
Contributor

powdahound commented Sep 20, 2013

Didn't realize those quiet options were fuzzy matching. Should give people the flexibility they need. Thanks!

@eykd

This comment has been minimized.

Copy link

eykd commented Oct 9, 2013

Hey, how do we enable these? Do we need to disable and re-enable the hook?

@powdahound

This comment has been minimized.

Copy link
Contributor

powdahound commented Oct 9, 2013

I think you'd have to remove it and re-add it, or use the API to edit the existing hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment