Fix xmpp-muc service #926

Merged
merged 2 commits into from Sep 2, 2014

Projects

None yet

4 participants

@aw
Contributor
aw commented Aug 30, 2014

I fixed 2 issues in the XMPP-MUC service:

  • The incorrect password was being sent as the room_password
  • Unknown error was always being raised on success.

I tested this locally and it works. /cc @atmos @lloydwatkin

@aw
Contributor
aw commented Aug 30, 2014

To be clear, this fixes the bug @lloydwatkin mentioned in issue #912

@lloydwatkin
Contributor

Hey,

Great! Could you change the quotes on exception messages to double quotes
please?

What I was seeing locally is the user join the much (I guess if there's no
room password it just ignores it on some servers). Then github XMPP client
would drop the connection before posting a chat message.

Hopefully we'll have this fully working very soon!
On 30 Aug 2014 09:26, "Alex Williams" notifications@github.com wrote:

To be clear, this fixes the bug @lloydwatkin
https://github.com/lloydwatkin mentioned in issue #912
#912


Reply to this email directly or view it on GitHub
#926 (comment)
.

@lloydwatkin
Contributor

...the dropped connection before posting makes complete sense from your
changes, so this looks great!

My lack of ruby too shining through! The last bit of ruby I did was with
the github buddycloud plugin a couple of years back :)
On 30 Aug 2014 09:26, "Alex Williams" notifications@github.com wrote:

To be clear, this fixes the bug @lloydwatkin
https://github.com/lloydwatkin mentioned in issue #912
#912


Reply to this email directly or view it on GitHub
#926 (comment)
.

@aw
Contributor
aw commented Sep 2, 2014

Ah no worries! I didn't notice the single/double quote thing either, thanks!

@kdaigle kdaigle merged commit 8765dd6 into github:master Sep 2, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@kdaigle
Member
kdaigle commented Sep 2, 2014

I'll get this out later today. Thanks for the collaboration on this! Extra bonus points. 💯

@lloydwatkin
Contributor

+1

Will be waiting on the update with log files at the ready :)

@kdaigle
Member
kdaigle commented Sep 2, 2014

This is now live. 🎊

@lloydwatkin
Contributor

Hi Kyle,

It seemed to go live within 30 minutes, all confirmed working. Thanks!

Lloyd
On 2 Sep 2014 19:50, "Kyle Daigle" notifications@github.com wrote:

This is now live. [image: 🎊]


Reply to this email directly or view it on GitHub
#926 (comment)
.

@aw
Contributor
aw commented Sep 3, 2014

goncalves_gif

@tekkub
Contributor
tekkub commented Sep 6, 2014

In before "@aw yea"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment