Permalink
Browse files

checking in the node_modules dir is best practice for app developers

according to the community since recent changes.

see: http://www.mikealrogers.com/posts/nodemodules-in-git.html
by @mikeal
(cherry picked from commit 44b47ec)
  • Loading branch information...
1 parent 85d1796 commit 541e85287f1f6077581271e1de6ca1160dcf6968 @aoberoi aoberoi committed Jan 6, 2012
Showing with 1 addition and 2 deletions.
  1. +1 −2 Node.gitignore
View
3 Node.gitignore
@@ -11,5 +11,4 @@ pids
logs
results
-node_modules
-npm-debug.log
+npm-debug.log

7 comments on commit 541e852

@ivanovyordan

I disagree with this article. I think, tat it' s better to keep an package.json file and lock dependencies versions there.

@wamatt

Agree with @ivanov-yordan

@bryanmikaelian

Agree with @wamatt and @ivanov-yordan as well. I prefer to use a package.json file.

@pablasso

Mike has a good point though, even while package.json can lock package modules versions it cannot lock those modules dependencies. That could turn out in a dependency nightmare in a production app.

@ivanovyordan

In fact, these modules also have their own package.json files with locked dependencies versions.

@MhdSyrwan

but repository size ,in this case, could be about 4MB by just using socket.io, is that acceptable ? how to solve this problem?

@ivanovyordan

A little bit old article http://blog.nodejitsu.com/package-dependencies-done-right.
You can be sure that all of your dependencies have their own package.json files.

Please sign in to comment.