Browse files

checking in the node_modules dir is best practice for app developers

according to the community since recent changes.

by @mikeal
(cherry picked from commit 44b47ec)
  • Loading branch information...
1 parent 85d1796 commit 541e85287f1f6077581271e1de6ca1160dcf6968 @aoberoi aoberoi committed Jan 6, 2012
Showing with 1 addition and 2 deletions.
  1. +1 −2 Node.gitignore
3 Node.gitignore
@@ -11,5 +11,4 @@ pids

7 comments on commit 541e852


I disagree with this article. I think, tat it' s better to keep an package.json file and lock dependencies versions there.


Agree with @ivanov-yordan


Agree with @wamatt and @ivanov-yordan as well. I prefer to use a package.json file.


Mike has a good point though, even while package.json can lock package modules versions it cannot lock those modules dependencies. That could turn out in a dependency nightmare in a production app.


In fact, these modules also have their own package.json files with locked dependencies versions.


but repository size ,in this case, could be about 4MB by just using, is that acceptable ? how to solve this problem?


A little bit old article
You can be sure that all of your dependencies have their own package.json files.

Please sign in to comment.