Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cordova ignores (android) for 3.4 #1061

Closed
wants to merge 1 commit into from

Conversation

@ccoenen
Copy link

commented Apr 29, 2014

Not much else to say: Here's what i ignore on a cordova/android project.

@arcresu

This comment has been minimized.

Copy link
Contributor

commented May 7, 2014

Thanks for this. Why should these specific rules be included (take a look at our contributing guidelines)? What do these files do, and is there any documentation describing them? What about non-android Cordova projects?

@ccoenen

This comment has been minimized.

Copy link
Author

commented May 7, 2014

Cordova (Wikipedia) is a Framework for creating mobile applications using HTML/CSS/JS. You can create apps for iOS, android, Windows Phone, Blackberry and a few more this way. The cordova project itself is open source and is developed over at apache foundation. It is the centerpiece of the more widely known "PhoneGap", so these rules would apply for that, too.

Unfortunately, there's little documentation on what can or can't be ignored right now. There's a little bit of discussion over at StackOverflow. That said: i'm using these ignores in a small team (~4 devs) successfully.

This changeset would apply to anyone using cordova, regardless of their editor and/or system settings.

@ccoenen

This comment has been minimized.

Copy link
Owner Author

commented on Cordova.gitignore in 0f896bd May 7, 2014

ant-build and ant-gen are directories where a build will end up. i.e. generated files that should generally be ignored.

@ccoenen

This comment has been minimized.

Copy link
Owner Author

commented on Cordova.gitignore in 0f896bd May 7, 2014

same here, only that this is the cordova library itself.

@ccoenen

This comment has been minimized.

Copy link
Owner Author

commented on Cordova.gitignore in 0f896bd May 7, 2014

local.properties will be used in the ant.build. (again: one for the project itself and one for the cordova library). These files will be regenerated on any system if they're missing. They contain paths that are likely to be different for every developer, so these should not be in version control. The files state this themselves in their comments.

@arcresu

This comment has been minimized.

Copy link
Contributor

commented May 7, 2014

The most relevant answer from the search you linked seems to have a completely different set of rules for android, and they seem to suggest that the directory layout isn't standardised in the first place. If people have different file layouts, then is this template really going to be useful here?

@ccoenen

This comment has been minimized.

Copy link
Owner Author

commented on Cordova.gitignore in 0f896bd May 7, 2014

your actual project will be copied into an internal directory per platform. These are derived files that add no value to the project. A cordova build <platform name> will do this automatically. No need to have them in git.

@ccoenen

This comment has been minimized.

Copy link
Author

commented May 7, 2014

the mentioned gitignore is ~2 years old. In recent months, a lot has changed in cordova. Also, it's referring to PhoneGap (which is a superset of cordova), which i'm not too familiar with right now.

In a Cordova 3.4 (current version) i don't even have the directories mentioned there.

@arcresu

This comment has been minimized.

Copy link
Contributor

commented May 7, 2014

Ok cool, so maybe it's worth waiting for things to stabilise a bit before we start recommending best practice here?

@ccoenen

This comment has been minimized.

Copy link
Author

commented May 7, 2014

Fine with me!

I'll keep my fork updated, when we go into other (cordova-)platforms. Maybe someone finds the work in progress useful or can comment on their experience, here.

@arcresu

This comment has been minimized.

Copy link
Contributor

commented May 7, 2014

Sounds good, we'll keep this request open until it seems more sensible to add the template.

@shiftkey

This comment has been minimized.

Copy link
Member

commented Nov 16, 2015

Superseded by #1758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.