Remove Meteor.gitignore #1521
Merged
Remove Meteor.gitignore #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are only two entries in this .gitignore, and both are not needed. - .meteor/local is already ignored by the standard Meteor .gitignore that is included with every project. This is redundant and should b left solely to the standard Meteor .gitignore in case this changes in the future. - .meteor/meteorite should no longer be in any Meteor project. Meteorite was a package manager for Meteor, but it has been replaced by an official package manager built into the Meteor CLI. This directory should not exist, except on out of date Meteor projects which already have this ignore present.
|
@lezed1 thanks for the details - do you have a link to some supporting docs about this so I can close this out? |
|
Here is the skeleton .gitignore with local already included: https://github.com/meteor/meteor/blob/devel/tools/skel/.meteor/.gitignore And here is the web interface of the package manager demonstration the install command which no longer uses meteorite: https://atmospherejs.com/meteor/accounts-github |
|
Is there anything else needed to be done for this pull request? |
|
Sorry for the wait; this looks good. Thanks! 🎉 |
u9E9F
pushed a commit
to u9E9F/gitignore
that referenced
this pull request
Jul 8, 2017
Remove Meteor.gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are only two entries in this .gitignore, and both are not needed.