Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore ApplicationInsights.config for Microsoft Azure #1815

Merged
merged 2 commits into from Jan 4, 2016

Conversation

@anderslundsgard
Copy link
Contributor

anderslundsgard commented Dec 28, 2015

The feature Application Insights in Microsoft Azure is cool but the config file ApplicationInsights.config should not be in version control.

According to https://azure.microsoft.com/sv-se/blog/upcoming-name-change-for-windows-azure/ Windows Azure is also renamed to Microsoft Azure.

Ignore Azure ApplicationInsights.config in VisualStudio.gitignore
@shiftkey

This comment has been minimized.

Copy link
Member

shiftkey commented Jan 1, 2016

@anderslundsgard do you have any links to documentation around this, so that others can understand this requirement?

@anderslundsgard

This comment has been minimized.

Copy link
Contributor Author

anderslundsgard commented Jan 2, 2016

Yes, here is a good introduction to ApplicationInsights http://docs.asp.net/en/latest/fundamentals/application-insights.html
The docs don't explicit tells that you should not share the config file but I guess others like me don't like to share the that is found in ApplicationInsights.config.

@shiftkey

This comment has been minimized.

Copy link
Member

shiftkey commented Jan 3, 2016

@anderslundsgard and for reference, can you share what sort of stuff is in your created ApplicationInsights.config file (with the contents sanitized wherever neessary)? I'm not really familiar with AppInsights, so it's mostly for my benefit 😁

It might also be worth submitting a PR to those docs to explain the .config file further - and that it can be safely ignored - but I won't hold this up further.

cc @ardalis for a 👍 on this PR

@anderslundsgard

This comment has been minimized.

Copy link
Contributor Author

anderslundsgard commented Jan 4, 2016

The element I got stuck on was the InstrumentationKey GUID that is your unique key to send statistics of site usage to Azure.

<ApplicationInsights xmlns="http://schemas.microsoft.com/ApplicationInsights/2013/Settings">
    ...
    <InstrumentationKey>xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx</InstrumentationKey>
</ApplicationInsights>
@shiftkey

This comment has been minimized.

Copy link
Member

shiftkey commented Jan 4, 2016

@anderslundsgard thanks, I'll get this in and if others decided they have differing opinions we can revisit

shiftkey added a commit that referenced this pull request Jan 4, 2016
Ignore ApplicationInsights.config for Microsoft Azure
@shiftkey shiftkey merged commit 578a7b7 into github:master Jan 4, 2016
@anderslundsgard

This comment has been minimized.

Copy link
Contributor Author

anderslundsgard commented Jan 5, 2016

Great, thanks!

peterblazejewicz added a commit to peterblazejewicz/generator-aspnet that referenced this pull request Jan 6, 2016
This commit update file state with upstream project.
Thanks!
@gitFurious

This comment has been minimized.

Copy link

gitFurious commented Jan 20, 2016

This change breaks continuous deployment from github through the Azure portal. The Azure deployment scripts expect ApplicationInsights.config to be there.

error MSB3030: Could not copy the file "D:\home\site\repository[WEBSITE]\ApplicationInsights.config" because it was not found. [D:\home\site\repository[WEBSITE][PROJECT].csproj]

InstrumentationKey isn't a secret. In fact, it's used on client side web pages.

@anderslundsgard

This comment has been minimized.

Copy link
Contributor Author

anderslundsgard commented Jan 20, 2016

Ok, I have not experienced that (yet) but then i totally agree with you @gitFurious.

@shiftkey

This comment has been minimized.

Copy link
Member

shiftkey commented Jan 21, 2016

@gitFurious thanks for bringing this to our attention. I'd gladly take a patch to revert this before the damage goes any further...

@shiftkey shiftkey mentioned this pull request Feb 10, 2016
bqh-kaiserhl pushed a commit to bqh-kaiserhl/gitignore that referenced this pull request Jul 8, 2017
Ignore ApplicationInsights.config for Microsoft Azure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.