Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upIgnore ApplicationInsights.config for Microsoft Azure #1815
Conversation
Ignore Azure ApplicationInsights.config in VisualStudio.gitignore
Windows Azure -> Microsoft Azure. Due to https://azure.microsoft.com/sv-se/blog/upcoming-name-change-for-windows-azure/
This comment has been minimized.
This comment has been minimized.
@anderslundsgard do you have any links to documentation around this, so that others can understand this requirement? |
This comment has been minimized.
This comment has been minimized.
Yes, here is a good introduction to ApplicationInsights http://docs.asp.net/en/latest/fundamentals/application-insights.html |
This comment has been minimized.
This comment has been minimized.
@anderslundsgard and for reference, can you share what sort of stuff is in your created It might also be worth submitting a PR to those docs to explain the cc @ardalis for a |
This comment has been minimized.
This comment has been minimized.
The element I got stuck on was the InstrumentationKey GUID that is your unique key to send statistics of site usage to Azure.
|
This comment has been minimized.
This comment has been minimized.
@anderslundsgard thanks, I'll get this in and if others decided they have differing opinions we can revisit |
Ignore ApplicationInsights.config for Microsoft Azure
This comment has been minimized.
This comment has been minimized.
Great, thanks! |
This commit update file state with upstream project. Thanks!
This comment has been minimized.
This comment has been minimized.
gitFurious
commented
Jan 20, 2016
This change breaks continuous deployment from github through the Azure portal. The Azure deployment scripts expect ApplicationInsights.config to be there.
InstrumentationKey isn't a secret. In fact, it's used on client side web pages. |
This comment has been minimized.
This comment has been minimized.
Ok, I have not experienced that (yet) but then i totally agree with you @gitFurious. |
This comment has been minimized.
This comment has been minimized.
@gitFurious thanks for bringing this to our attention. I'd gladly take a patch to revert this before the damage goes any further... |
Ignore ApplicationInsights.config for Microsoft Azure
anderslundsgard commentedDec 28, 2015
The feature Application Insights in Microsoft Azure is cool but the config file ApplicationInsights.config should not be in version control.
According to https://azure.microsoft.com/sv-se/blog/upcoming-name-change-for-windows-azure/ Windows Azure is also renamed to Microsoft Azure.