Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JetBrains Rider (.NET IDE from JetBrains) specific files #1865

Merged
merged 1 commit into from Feb 18, 2016

Conversation

Projects
None yet
3 participants
@hmemcpy
Copy link
Contributor

commented Feb 18, 2016

This ignores the .idea directory that is placed in the root of the solution, and a metadata file .sln.iml that is created.

@shiftkey

This comment has been minimized.

Copy link
Member

commented Feb 18, 2016

Not sure a blanket .idea rule here fits with the official docs but it seems like everyone else just does this.

@shiftkey

This comment has been minimized.

Copy link
Member

commented Feb 18, 2016

Thanks!

shiftkey added a commit that referenced this pull request Feb 18, 2016

Merge pull request #1865 from hmemcpy/patch-1
Adding JetBrains Rider (.NET IDE from JetBrains) specific files

@shiftkey shiftkey merged commit a392c48 into github:master Feb 18, 2016

bqh-kaiserhl pushed a commit to kaiserhl/gitignore that referenced this pull request Jul 8, 2017

Merge pull request github#1865 from hmemcpy/patch-1
Adding JetBrains Rider (.NET IDE from JetBrains) specific files
@CoskunSunali

This comment has been minimized.

Copy link
Contributor

commented on VisualStudio.gitignore in e429db1 Mar 10, 2019

This comment has been minimized.

Copy link
Contributor

replied Mar 10, 2019

By the way, I don't know why Rider should be a part of VS ignore list since it is not a part of VS in any way.

@shiftkey

This comment has been minimized.

Copy link
Member

commented on e429db1 Mar 11, 2019

@CoskunSunali I'd take a PR to undo this because Global/JetBrains.gitignore should be used in this situation...

This comment has been minimized.

Copy link
Contributor Author

replied Mar 11, 2019

Just saw it now... I added this back in 2016 when Rider was pre-release. It was probably not up-to-standards.

This comment has been minimized.

Copy link
Contributor

replied Mar 11, 2019

@shiftkey I'd really love to but don't have the time these days. I might forget later so I cannot promise :/ I manually removed the entry from my own ignore file, just wanted to ping you so that further developers using the templates don't have issues. Hope you understand.

This comment has been minimized.

Copy link
Contributor

replied Mar 11, 2019

@shiftkey Anyway let me do that.

This comment has been minimized.

Copy link
Member

replied Mar 11, 2019

@CoskunSunali it's pretty fast within the web flow for small changes:

Screen Shot 2019-03-11 at 9 58 46 AM

  • make the change and commit
  • the next step will create the PR for you

This comment has been minimized.

Copy link
Contributor

replied Mar 11, 2019

@shiftkey Please see #2991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.