Update CSharp.gitignore #226

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@jrwren

No description provided.

@mibe

I suggest to put these things in the VisualStudio.gitignure under Global. Most entries do not come from C#, but from VisualStudio (like .suo 1) or an VS addon (like nuget 2).

@jrwren

i don't see how that is different from bin, obj, and TestResults.

bin and obj are not CSharp related, but instead are artifacts from msbuild. Using CSC directly would not inherently create these folders.

Same is true of TestResults, except it would be msbuild invoking mstest instead of msbuild invoking CSC.

The decision for which goes where seems arbitrary.

@mibe

You're right, the bin and obj would be better placed in a seperate msbuild.gitignore file.

Do you know of any language-specific ignorable C# files? If not, maybe the best thing is to completely remove the CSharp.gitignore file.

@jrwren

I do not know of any.

Maybe CSharp.gitignore should be empty with a comment to checkout msbuild.gitignore and VisualStudio.gitignore?

@mibe

Sounds good to me.

@defunkt
GitHub member

+1 remove this file - can someone do that? Thanks!

@defunkt defunkt closed this Apr 18, 2012
@mibe mibe added a commit that referenced this pull request Apr 18, 2012
@mibe mibe First try to clean up the files for the .NET system.
CSharp.gitignore & VB.NET.gitignore were merged into msbuild.gitignore and VisualStudio.gitignore. The two files now contain a note to better use the msbuild and VisualStudio file. See also the discussion in the pull requests #163 and #226. Comments are greatly appreciated!
1ad3160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment