It is a security issue BUT it shouldn't be on gitignore. Adding it to the gitignore inhibits development (the app won't boot without it)
what do you think @aldo-roman @charliesome
I came up with this issue when deploying to Heroku. I still think it is valuable to avoid the token in git. If you need to deploy, you can (for example) include it manually in server.
Remember that motivation for this was new developers publishing a security token it without noticing.
If the secret_token is not there you can't deploy and people who fork the project will have an unusable app, everyone has to manually create the secret_token.rb. This is also hard for the newbie deploying for first time, or contributing on other rails projects for the first time.
I'm not saying you are wrong but for github(sharing) I think it's better not to have the secret_token on .gitignore.
More on securing secret_token http://daniel.fone.net.nz/blog/2013/05/20/a-better-way-to-manage-the-rails-secret-token/
I generally would prefer to avoid ignoring files which are essential for a project to work properly, but I also see the security issue. I think that the best compromise would be to ignore sensitive files by default, but add a comment starting with TODO which says to comment out the rule if you're okay with secret stuff going into the repo.
That way you don't accidentally make things public unless you've explicitly taken the step to comment out the rule and acknowledged what is entailed. Would that work for everyone? If so could we get this PR updated to account for the similar case of secrets.yml which was added in the meantime?
I have merged and updated the PR
Thanks, but currently there are changes to 3 templates. Can we keep it to Rails here?
add notice about secret files
@arcresu Must have messed something up in the merge, Fixed 👍
Excellent, thanks for persevering after all this time ✨