Refactor Node.gitignore with comments #913

Merged
merged 6 commits into from Feb 28, 2014

Projects

None yet

3 participants

@stuartpb
Contributor
stuartpb commented Jan 3, 2014

This restructures the NodeJS gitignore to include comments explaining under what category each pattern is excluded, including a note that node_modules should sometimes not be gitignored as a Node convention.

The "build" directory is lost in this refactor, as many JS projects do wish to include a minified/concatenated version of their source in the "build" folder in source control.

@stuartpb stuartpb Refactor Node.gitignore with comments
The "build" directory is lost in this refactor, as many JS projects
do wish to include a minified/concatenated version of their source
in the "build" folder in source control.
d79a88b
Contributor
aroben commented Jan 7, 2014

Thanks for the cleanup! It's super-helpful.

Unfortunately I merged some other changes to this file before I got to your PR. Could you update your branch to bring them into your great new organization?

stuartpb added some commits Jan 7, 2014
@stuartpb stuartpb Clarify node_modules comment
Now linking to the official npm FAQ entry (with tl;dr) rather than straight to mikeal's blog post
935e9b4
@stuartpb stuartpb Add build/Release to Node gitignore
This re-covers the http://nodejs.org/api/addons.html case for which the "build" directory was added in 0068641, but doesn't break cross-environment projects that use the build directory for including concatenated/minified source. Mazel tov!
b0440f9
@stuartpb stuartpb Add `coverage` directory, rename coverage heading 8845a34
@stuartpb stuartpb Add .grunt directory bdf8aec
Contributor
stuartpb commented Jan 7, 2014

I've implemented some more commits that implement / supersede the intervening changes.

Collaborator
arcresu commented Jan 30, 2014

Sorry, but this PR's outdated again. Could you bring it up to date so that it's mergeable? Also I would suggest removing your heading comments (starting with #) since they don't add a lot and make the file harder to read. The other comments (with ## changed to #), however, are helpful, so thanks for that!

@aroben aroben merged commit f3f11fb into github:master Feb 28, 2014
Contributor
aroben commented Feb 28, 2014

I cleaned this up myself instead of making @stuartpb go through another round just because I missed his fixups last time.

Contributor

Thanks!

@stuartpb stuartpb deleted the stuartpb:node-patch branch Mar 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment